GNOME Bugzilla – Bug 658993
Two GtkGrid spacing issues
Last modified: 2011-09-13 23:13:27 UTC
Orca's Preferences dialog was recently redone. As part of this change, all instances of GtkHBox, GtkVBox, GtkBox, and GtkTable were converted to use GtkGrid. In this process, I discovered that the GtkGrid row-spacing and column-spacing properties seemed to be backwards. Benjamin has since fixed this: http://git.gnome.org/browse/gtk+/commit/?id=d717a2dcfc8603561f8a0f78982244e8b8fd9006 Unfortunately, there were two grid instances where I failed to ensure things would look as expected once the Gtk+ bug was fixed. And those now look really, really bad. :-/ See attached screenshot and weep.
Created attachment 196440 [details] [review] Fix We're in GUI freeze so I need to get approval from the Release Team before I can commit this.
Created attachment 196442 [details] screenshot
Created attachment 196443 [details] screenshot 2 - what the gui is meant to look like This screenshot was taken prior to the Gtk+ fix. And it's what the gui will once again look like should the fix be approved for freeze break.
Comment on attachment 196440 [details] [review] Fix http://git.gnome.org/browse/orca/commit/?id=ca4eabda3684a97c8c350ee677701cbb5511f0f0
Approval: https://mail.gnome.org/archives/release-team/2011-September/msg00133.html Doc Team announcement: https://mail.gnome.org/archives/gnome-doc-list/2011-September/msg00123.html Closing as FIXED.