After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658895 - GOA plugin should only save params of GOA accounts
GOA plugin should only save params of GOA accounts
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Accounts
2.33.x
Other Linux
: Normal normal
: 3.2
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2011-09-13 09:58 UTC by Guillaume Desmottes
Modified: 2011-09-14 08:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GOA plugin: only save parameters from GOA accounts (1.71 KB, patch)
2011-09-13 10:19 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2011-09-13 09:58:42 UTC 
Original report: https://bugs.freedesktop.org/show_bug.cgi?id=40740

Looks like the plugin is storing info of all newly created account. We should filter them out and only save info for GOA accounts.
Comment 1 Guillaume Desmottes 2011-09-13 10:19:42 UTC 
Created attachment 196349 [details] [review]
GOA plugin: only save parameters from GOA accounts

We should let MC deal with normal accounts.
Comment 2 Danielle Madeley 2011-09-14 00:53:15 UTC 
Review of attachment 196349 [details] [review]:

Good catch. Looks good.

Do you also need this for commit()?
Comment 3 Guillaume Desmottes 2011-09-14 08:00:47 UTC 
No, this one doesn't depend of one specific account.
Comment 4 Guillaume Desmottes 2011-09-14 08:01:11 UTC 
Attachment 196349 [details] pushed as 9219415 - GOA plugin: only save parameters from GOA accounts