After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658875 - Should limit Num Lock warning to notebooks
Should limit Num Lock warning to notebooks
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkEntry
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: gtk-bugs
gtk-bugs
: 660610 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-09-13 05:29 UTC by Urmas
Modified: 2012-03-22 04:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Urmas 2011-09-13 05:29:49 UTC 
In current versions, GtkEntry's for passwords show warning if NumLock mode is on. That is normal condition for desktops which has full-sized keyboard with num block; that warning is unneeded and distracting.

Could it be limited to cases when compact keyboard, such as notebook one, is present?
Comment 1 Matthias Clasen 2011-10-01 14:21:34 UTC 
*** Bug 660610 has been marked as a duplicate of this bug. ***
Comment 2 Rimas Kudelis 2011-11-08 18:26:36 UTC 
On desktops, I would suggest to warn about numlock being off instead. It should be configurable somehow...
Comment 3 Marc Deslauriers 2012-02-06 13:12:42 UTC 
I don't think this is an easy problem to solve. The status of the NumLock key is hardware specific, and a lot of hardware lies about it's status.

For example, on recent Thinkpads, the BIOS is set to "Thinkpad NumLock - Independent", which means the Thinkpad hardware tracks the built in keyboard numlock and the external keyboard numlock independently, so the numlock status as read by gtk+ is always wrong: once you hit NumLock, you can't get the warning indicator to go away again.

Although an option could be added to Gtk+ to disable the numlock warning, I'm afraid shipping it with the warning turned on just causes too many issues with different hardware to be worthwhile and will likely cause user confusion.

Honestly, I would just revert the following commit, and forget about it:

http://git.gnome.org/browse/gtk+/commit/gtk/gtkentry.c?id=85e3f22c19b1322a7469f985feedf55fdff0dd6f
Comment 4 Matthias Clasen 2012-03-22 04:17:13 UTC 
I've done this now