After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658856 - Build system is broken for 64bit
Build system is broken for 64bit
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: general
Git master
Other All
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2011-09-12 20:59 UTC by Dieter Verfaillie
Modified: 2011-09-13 20:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove common_ldflags from Makefile.am as it is no longer used. (811 bytes, patch)
2011-09-12 21:04 UTC, Dieter Verfaillie 		committed Details | Review
AM_CHECK_PYTHON_LIBS does not work for lib64 (3.51 KB, patch)
2011-09-12 21:04 UTC, Dieter Verfaillie 		none Details | Review
AM_CHECK_PYTHON_LIBS does not work for lib64 (3.51 KB, patch)
2011-09-13 12:39 UTC, Dieter Verfaillie 		committed Details | Review

Description Dieter Verfaillie 2011-09-12 20:59:00 UTC 
As discussed on IRC with J5, I seem to have broken the build
system with the python.m4 improvements done some time ago,
notably AM_CHECK_PYTHON_LIBS. Looking further into this, linking
to libpython is not required on Linux systems, but it is on
Windows. Yay.

Here's a patch that:
- only calls AM_CHECK_PYTHON_LIBS in configure.ac when building
  Windows binaries
- properly sets LIBADD to contain PYTHON_LIBS on Windows only
- provides clear comments that linking to libpython is a Windows
  only thing.
Comment 1 Dieter Verfaillie 2011-09-12 21:04:09 UTC 
Created attachment 196306 [details] [review]
Remove common_ldflags from Makefile.am as it is no longer used.
Comment 2 Dieter Verfaillie 2011-09-12 21:04:25 UTC 
Created attachment 196307 [details] [review]
AM_CHECK_PYTHON_LIBS does not work for lib64
Comment 3 Dieter Verfaillie 2011-09-13 12:39:41 UTC 
Created attachment 196364 [details] [review]
AM_CHECK_PYTHON_LIBS does not work for lib64

Corrected patch, tested with jhbuild on a Linux machine and
with MinGW/MSYS on Windows.
Comment 4 johnp 2011-09-13 16:53:15 UTC 
Comment on attachment 196364 [details] [review]
AM_CHECK_PYTHON_LIBS does not work for lib64

looks good.
Comment 5 johnp 2011-09-13 20:38:54 UTC 
Attachment 196306 [details] pushed as 863c087 - Remove common_ldflags from Makefile.am as it is no longer used.
Attachment 196364 [details] pushed as fcd457d - AM_CHECK_PYTHON_LIBS does not work for lib64