After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658853 - Show glyph for end of ayah mark and other signs spanning numbers
Show glyph for end of ayah mark and other signs spanning numbers
Status: RESOLVED FIXED
Product: gucharmap
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gucharmap maintainers
gucharmap maintainers
Depends on:
Blocks:
 
 
Reported: 2011-09-12 19:40 UTC by Khaled Hosny
Modified: 2016-08-01 18:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Show glyphs for Arabic signs spanning numbers (1.14 KB, patch)
2011-09-12 19:40 UTC, Khaled Hosny
none Details | Review
Updated patch (1.35 KB, patch)
2016-07-29 05:41 UTC, Khaled Hosny
none Details | Review

Description Khaled Hosny 2011-09-12 19:40:11 UTC
Created attachment 196298 [details] [review]
Show glyphs for Arabic signs spanning numbers

These signs have Cf general category, however, the Unicode book (version 6, p.247) says "Unlike most other format control characters, however, they should be rendered with a visible glyph, even in circumstances where no suitable digit or sequence of digits follows them in logical order."

The attached patch makes gucharmap_unichar_isgraph() return true for those characters.
Comment 1 Khaled Hosny 2012-05-14 12:24:04 UTC
Any comment on the patch?
Comment 2 Khaled Hosny 2013-11-14 18:11:06 UTC
Is guchamap still being maintained?
Comment 3 Khaled Hosny 2016-07-29 05:17:49 UTC
Any comment on this issue or the patch, it has been 6 years now…
Comment 4 Khaled Hosny 2016-07-29 05:41:09 UTC
Created attachment 332329 [details] [review]
Updated patch

Here is an updated patch for Unicode 9.0, with a direct link to the PDF file of the standard.
Comment 5 Christian Persch 2016-07-29 07:33:35 UTC
Comment on attachment 332329 [details] [review]
Updated patch

Shouldn't this also apply to U+070F and U+110BD ? Together with those listed in the patch, that's all of Prepended_Concatenation_Mark.
Comment 6 Khaled Hosny 2016-07-29 13:11:52 UTC
I guess so. The Prepended_Concatenation_Mark is new in 9.0, but reading http://www.unicode.org/review/pri310/pri310-background.html and http://unicode.org/reports/tr44/#Prepended_Concatenation_Mark suggests that it is introduced for purposes like the one here, so I think it is the right property to check.

But it seems that neither GLib nor Gucharmap has code to access such character properties.
Comment 7 Christian Persch 2016-08-01 18:42:12 UTC
Committed to master with the additions from comment 5.

Instead of parsing the unicode data file for this, just hardcode the few existing characters for now.
Comment 8 Khaled Hosny 2016-08-01 18:57:07 UTC
Thanks Christian!