After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658750 - Password prompt needs desktop file
Password prompt needs desktop file
Status: RESOLVED FIXED
Product: gnome-keyring
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME keyring maintainer(s)
GNOME keyring maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-09-11 14:09 UTC by Bastien Nocera
Modified: 2011-09-15 09:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Make .desktop file match process (995 bytes, patch)
2011-09-15 09:23 UTC, Bastien Nocera
committed Details | Review

Description Bastien Nocera 2011-09-11 14:09:48 UTC
The password box shows up as "Gnome-keyring-prompt-3" in gnome-shell, instead of a decent (translated) name. It also means that it has a crappy icon in alt-tab as gnome-shell doesn't know the real icon name for it.
Comment 1 Stef Walter 2011-09-15 09:05:40 UTC
Too late to fix this for Gnome 3.2. Once bug 652459 is fixed, this will no longer be a problem.
Comment 2 Bastien Nocera 2011-09-15 09:19:01 UTC
Not too late for 3.2. You probably already have the string in your .po files, so wouldn't even require a string freeze break request.
Comment 3 Bastien Nocera 2011-09-15 09:23:27 UTC
Created attachment 196596 [details] [review]
Make .desktop file match process

The keyring prompt was showing up without a nice icon or
application name in the shell. Turns out that the binary
name didn't match the one in the .desktop file.
Comment 4 Bastien Nocera 2011-09-15 09:24:05 UTC
In fact, you already had the desktop file for it, but it was broken. Untested patch above.
Comment 5 Bastien Nocera 2011-09-15 09:41:07 UTC
Patch works as expected.
Comment 6 Stef Walter 2011-09-15 09:45:59 UTC
Thanks! Looks good then. Please go ahead and merge into gnome-keyring master.
Comment 7 Bastien Nocera 2011-09-15 09:50:57 UTC
Pushed to gnome-3-0 and master.

Attachment 196596 [details] pushed as 847edb0 - Make .desktop file match process