After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658664 - Add context to ambiguous strings in end session dialogs
Add context to ambiguous strings in end session dialogs
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.2.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-09-09 16:26 UTC by Piotr Drąg
Modified: 2011-10-21 20:34 UTC
See Also:
GNOME target: ---
GNOME version: 3.3/3.4

Attachments
Patch to add context in end session code (2.66 KB, patch)
2011-09-09 16:29 UTC, Piotr Drąg 		committed Details | Review

Description Piotr Drąg 2011-09-09 16:26:05 UTC 
Some of the strings in js/ui/endSessionDialog.js should have context, as they are identical yet used in very different places (title vs. button). The following patch fixes this.

I don't think it's as important as a bug #658414, so I'd like to commit it after the string freeze for 3.2.
Comment 1 Piotr Drąg 2011-09-09 16:29:05 UTC 
Created attachment 196121 [details] [review]
Patch to add context in end session code
Comment 2 Piotr Drąg 2011-10-18 16:46:56 UTC 
Is it ok to push these now, as gnome-shell has been branched for 3.2?
Comment 3 Ray Strode [halfline] 2011-10-21 20:18:11 UTC 
Comment on attachment 196121 [details] [review]
Patch to add context in end session code

seems fine