GNOME Bugzilla – Bug 658609
Handle subtitles with non raw caps video streams in subtitle overlay
Last modified: 2011-09-15 08:52:59 UTC
In the following branch I've implemented handling of subtitles for the non raw video stream use case. http://cgit.freedesktop.org/~adn770/gst-plugins-base/log/?h=subtitles Please could you provide me some feedback?
Instead of judging from the pad caps you should add/remove the converters for non-raw video streams during negotiation when you have the negotiated caps. Otherwise you'll get problems with renderers that support raw and non-raw video. Other than that this is the correct thing to do!
Sebastian there's a new version of the patch at the following url. http://cgit.freedesktop.org/~adn770/gst-plugins-base/log/?h=subtitles2 I've fixed some minor issues on the code but apart of theme essentially is the same approach. About the corner case we talked on IRC about switching from raw to non war and vice versa. I've tried to generate a matroska multivideo+subtitles clip with no luck and I couldn't find a way to reproduce the potential issue. So I'm proposing to move forward the current proposed patch and I'll take care in the future for whatever bug triggered by my changes.
Module: gst-plugins-base Branch: master Commit: 596c75b541c30e0db233f16e3894b65b0ad47712 URL: http://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=596c75b541c30e0db233f16e3894b65b0ad47712 Author: Josep Torra <n770galaxy@gmail.com> Date: Mon Sep 12 15:46:46 2011 +0200 subtitleoverlay: gracefully handle non raw video streams Implement handling of non raw video streams by avoiding colorspace elements and autoplugging a compatible renderer if available. Fallback to passthrough if no compatible renderer is found. Module: gst-plugins-base Branch: master Commit: 8f8ad316ce303e39689beeb23f335d3b5c359283 URL: http://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=8f8ad316ce303e39689beeb23f335d3b5c359283 Author: Josep Torra <n770galaxy@gmail.com> Date: Mon Sep 12 15:48:59 2011 +0200 Revert "playsink: only add text overlay if vido sink also accepts raw caps" This reverts commit a22faad18a73a27a2a0c903748c1a355df4d8c13. Instead of disabling subtitles completelly when video stream have custom caps, just let the sutbtileoverlay cope with them as now it's able to. Fixes the issue.