After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658598 - Main.keyboard.actor is null
Main.keyboard.actor is null
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: keyboard
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-09-08 19:11 UTC by Marina Zhurakhinskaya
Modified: 2011-09-22 12:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
messageTray: don't worry about the osk when it's not there (1.20 KB, patch)
2011-09-08 20:50 UTC, Dan Winship 		accepted-commit_now Details | Review
messageTray: fix a warning (1.09 KB, patch)
2011-09-09 13:45 UTC, Dan Winship 		committed Details | Review

Description Marina Zhurakhinskaya 2011-09-08 19:11:02 UTC 
I'm getting this error when clicking on the summary item to bring the summary notification down or clicking on the top panel when the onscreen keyboard is not enabled. It's probably just a matter of checking if Main.keyboard.actor is not null before calling a function on it.

    JS ERROR: !!!   Exception was: TypeError: Main.keyboard.actor is null
    JS ERROR: !!!     lineNumber = '287'
    JS ERROR: !!!     fileName = '"/home/mazik/gnome-shell/source/gnome-shell/js/ui/messageTray.js"'
    JS ERROR: !!!     stack = '"([object _private_Clutter_Stage],[object _private_Clutter_Event])@/home/mazik/gnome-shell/source/gnome-shell/js/ui/messageTray.js:287
"'
    JS ERROR: !!!     message = '"Main.keyboard.actor is null"'
Comment 1 Dan Winship 2011-09-08 20:50:52 UTC 
Created attachment 196037 [details] [review]
messageTray: don't worry about the osk when it's not there
Comment 2 Dan Winship 2011-09-09 13:45:09 UTC 
Created attachment 196115 [details] [review]
messageTray: fix a warning

Check for click in keyboardBox rather than Main.keyboard.actor, since
the latter won't exist when the keyboard is hidden.

====

simpler fix
Comment 3 drago01 2011-09-09 16:11:06 UTC 
Review of attachment 196115 [details] [review]:

Makes sense.
Comment 4 Dan Winship 2011-09-15 12:35:12 UTC 
Attachment 196115 [details] pushed as fd25cf3 - messageTray: fix a warning