After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658519 - [sudoku] Borders are unclear in most themes
[sudoku] Borders are unclear in most themes
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: gnome-sudoku
3.1.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2011-09-08 02:32 UTC by Jeremy Bicha
Modified: 2011-11-29 00:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
sudoku: fix borders (1.03 KB, patch)
2011-10-08 13:59 UTC, Edward Sheldrake 		accepted-commit_now Details | Review

Description Jeremy Bicha 2011-09-08 02:32:07 UTC 
I agree with the reporter that the borders are indistinct. I do notice a slight difference between internal borders and the 3x3 borders but looking at Adwaita and Ambiance (the two themes I expect to be used most), it is difficult to even see that there is a grid at all.

Original bug copied from https://bugs.launchpad.net/bugs/844385
This is not so much a bug as a design problem in the latest version of gnome-sudoku, but it leads to serious playability issues. Since 3x3 squares are relevant to game play, there is typically a darker border around those squares as compared to the individual squares. The only theme where this border is in fact darker is high contrast inverse. With the high contrast them there is no border at all, even around the individual squares. With most others, (Adwaita, Ambiance) there is no difference in the thickness of the individual and 3x3 borders. The game should display correctly regardless of theme.
Comment 1 Edward Sheldrake 2011-10-08 13:59:57 UTC 
Created attachment 198600 [details] [review]
sudoku: fix borders

There's a python traceback in the terminal:

CRITICAL:root:set_bg_color handed Bad color: black
Traceback (most recent call last):

+ Trace 228717

  • File "/usr/lib/python2.7/site-packages/gnome_sudoku/gsudoku.py", line 59 in set_bg_color 
    color = Gdk.color_parse(color)[1]
TypeError: 'Color' object does not support indexing 

Fixing that fixes the borders.
Comment 2 Thomas Andersen 2011-10-10 22:53:34 UTC 
Comment on attachment 198600 [details] [review]
sudoku: fix borders

Looks good. Thanks Edward
Comment 3 Jeremy Bicha 2011-10-19 15:01:41 UTC 
Yes, I confirm that this patch works well in Ubuntu. Edward, please commit if you have commit privileges.
Comment 4 Thomas Andersen 2011-11-29 00:40:28 UTC 
committed to master:
http://git.gnome.org/browse/gnome-games/commit/?id=84f76cb5f6c554e5c7b79d6be7e5a55c5c180d82

and to the 3.2 branch:
http://git.gnome.org/browse/gnome-games/commit/?h=gnome-3-2&id=a91b3962d121f4042e7029e30a5c1423dfb0c130

Thanks again. Sorry that it took so long to land