After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658513 - GtkNotebook paint method should check page allocation
GtkNotebook paint method should check page allocation
Status: RESOLVED OBSOLETE
Product: gtk+
Classification: Platform
Component: Widget: GtkNotebook
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2011-09-07 23:35 UTC by Peter Bloomfield
Modified: 2015-02-28 14:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (1.05 KB, text/plain)
2011-09-07 23:35 UTC, Peter Bloomfield
Details

Description Peter Bloomfield 2011-09-07 23:35:53 UTC
Created attachment 195940 [details]
proposed patch

GtkNotebook's paint method assumes that if the current page is non-NULL, its allocation has been populated.  The allocation is populated in a size-allocate idle callback, while painting is called in response to the draw signal, which may be emitted in another idle callback, with a higher priority.  If the paint method is called when the page is non-NULL but the allocation is still initialized to zeros, it calls gtk_render_frame_gap with a negative offset, which then emits a critical warning.

The paint method would be more robust if it checked for a populated page allocation--patch attached.
Comment 1 Peter Bloomfield 2015-02-28 14:33:37 UTC
I haven't seen that warning in a long time, so the bug appears to be OBSOLETE...