After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658472 - Add newly created custom format to custom format page
Add newly created custom format to custom format page
Status: RESOLVED FIXED
Product: libgoffice
Classification: Other
Component: General
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2011-09-07 14:37 UTC by Andreas J. Guelzow
Modified: 2011-09-07 17:30 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
possible patch (5.17 KB, patch)
2011-09-07 16:57 UTC, Andreas J. Guelzow
none Details | Review

Description Andreas J. Guelzow 2011-09-07 14:37:04 UTC
In go-format-sel.c we have:

/* TODO We should add the list of other custom formats created.
 *      It should be easy.  All that is needed is a way to differentiate
 *      the std formats and the custom formats in the GOFormat hash.
*/

ie. Currently the custom format page of the selector do not include any formats created by the user for this spreadsheet, but this would be very desirable.

We need to
1) add a field to GOFormat flagging it as build-in
2) set that flag when we create the standard formats
3) when we create the custom page, scan through the hash for non-build-in formats and add them.
Comment 1 Andreas J. Guelzow 2011-09-07 16:57:12 UTC
Created attachment 195902 [details] [review]
possible patch

This patch adds all non-build-in formats currently in the style_hash to the custom page.
Comment 2 Andreas J. Guelzow 2011-09-07 17:04:07 UTC
As long as we have bug #658490 we can't apply this patch since to many nonsense formats would be shown!
Comment 3 Andreas J. Guelzow 2011-09-07 17:30:34 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.