After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658459 - Accessibility support is broken in 3.1.91
Accessibility support is broken in 3.1.91
Status: RESOLVED DUPLICATE of bug 658562
Product: gnome-shell
Classification: Core
Component: general
3.1.x
Other Linux
: Normal blocker
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-09-07 12:58 UTC by Vincent Untz
Modified: 2011-09-08 16:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
shell-a11y: Adjust for change in type of atk-bridge-location key (795 bytes, patch)
2011-09-07 13:11 UTC, Vincent Untz 		reviewed Details | Review
a11y bridge location path gsettings is a bytestring (815 bytes, patch)
2011-09-07 15:56 UTC, Alban Browaeys 		none Details | Review

Description Vincent Untz 2011-09-07 12:58:30 UTC 
** (gnome-shell:4456): WARNING **: Accessibility: invalid module path (NULL)

** (gnome-shell:4456): WARNING **: Accessibility: error loading the atk-bridge. Although the accessibility on the system is enabled and clutter accessibility is also enabled, accessibility support on GNOME Shell will not work

Investigating a bit, and I guess this is because of bug 645321: the atk-bridge-location key is not a string anymore, but a bytestring.
Comment 1 Vincent Untz 2011-09-07 13:11:03 UTC 
Created attachment 195871 [details] [review]
shell-a11y: Adjust for change in type of atk-bridge-location key

I couldn't test the patch, but I guess something like this would work.
Comment 2 Vincent Untz 2011-09-07 13:12:42 UTC 
Note: it might be better to do use g_variant_get_bytestring() if it does some additional checks
Comment 3 Alejandro Piñeiro Iglesias (IRC: infapi00) 2011-09-07 13:20:10 UTC 
(In reply to comment #1)

> I couldn't test the patch, but I guess something like this would work.

Ok, I will test this patch
Comment 4 Florian Müllner 2011-09-07 13:22:11 UTC 
Review of attachment 195871 [details] [review]:

Looks good to me - but then I came up with an identical patch, so take this with a grain of salt :-)
Comment 5 Alejandro Piñeiro Iglesias (IRC: infapi00) 2011-09-07 13:38:49 UTC 
(In reply to comment #4)
> Review of attachment 195871 [details] [review]:
> 
> Looks good to me - but then I came up with an identical patch, so take this
> with a grain of salt :-)

Does this means that you tested Vincent patch?
Comment 6 Florian Müllner 2011-09-07 13:53:31 UTC 
(In reply to comment #5)
> Does this means that you tested Vincent's patch?

No, I would have mentioned that.
Comment 7 Alban Browaeys 2011-09-07 15:56:16 UTC 
Created attachment 195897 [details] [review]
a11y bridge location path gsettings is a bytestring

The other patch does not work , ie the char pointer ends up ponting to a bytestring and .xsession-errors still shows the error about reading the atk-bridge-location key.
This patch works.
Comment 8 Alban Browaeys 2011-09-07 15:58:06 UTC 
Also note that one can use g_variant_get_bytestring instead of the dup version . Though this require more invasive changes , ie switch most char * to const char * and removal of the g_free of bridge_path.
Comment 9 Alban Browaeys 2011-09-08 14:51:19 UTC 
Duplicate of https://bugzilla.gnome.org/show_bug.cgi?id=658562
Comment 10 Dan Winship 2011-09-08 16:20:48 UTC 

*** This bug has been marked as a duplicate of bug 658562 ***