GNOME Bugzilla – Bug 658446
Add translation comment for wrong password notice string
Last modified: 2017-05-29 10:23:51 UTC
The string "Several password entered have been incorrect, and your access will be locked out after further failures." seems to be displayed when more than one attempt is allowed. This detail may be missed by translator. A comment that warns that this is not the "This is the last chance" string would be nice.
Created attachment 198260 [details] [review] Comment added My English is quite bad, so I have added a slightly different version of your original comment to gio/gtlspassword.c.
Created attachment 198501 [details] [review] Edited the display messages Beginning to sink my teeth into open-source projects.
Review of attachment 198501 [details] [review]: I don't see anything wrong with the strings as they are currently, so I don't see why you're proposing this change. This is not what this bug report is about. The issue is that "further failureS" may be overlooked or missed by translators and they might not notice that the user still has a few attempts left, which might lead to some inaccuracies in translations (it happened to me and the translation reviewer brought it to my attention which is why I filed this bug). I'd mark the patch as rejected but I'm not the maintainer of this module, so I'm not the one to decide that.
Why do you just not add /*LAST CHANCE STRING*/ comment under the first if statement? You probably have this sorted by now anyway.
Review of attachment 198501 [details] [review]: > I'd mark the patch as rejected but I'm not the maintainer of this module, so I'm not the one to decide that. I agree.
I pushed Juan’s patch with some minor tweaks to the comment and commit message for formatting.