After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658443 - theoraenc: do not automatically override quality when using target bitrate
theoraenc: do not automatically override quality when using target bitrate
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal normal
: 0.10.36
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-09-07 10:15 UTC by Vincent Penquerc'h
Modified: 2011-09-07 11:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
theoraenc: do not automatically override quality when using target bitrate (1.43 KB, patch)
2011-09-07 10:15 UTC, Vincent Penquerc'h 		committed Details | Review

Description Vincent Penquerc'h 2011-09-07 10:15:38 UTC 
If both quality and bitrate are set, libtheora will try to meet
both constraints, causing it to prefer emitting a smaller number
of good frames, to emitting the full number of frames that would
not meet the requested quality. This causes a slideshow effect
when the bitrate is low and the quality is high. And the default
theoraenc is high (48/63).

So only set quality when it is requested, and leave it unset
otherwise.
Comment 1 Vincent Penquerc'h 2011-09-07 10:15:40 UTC 
Created attachment 195851 [details] [review]
theoraenc: do not automatically override quality when using target bitrate
Comment 2 Sebastian Dröge (slomo) 2011-09-07 11:28:08 UTC 
commit cea0ac790f900c79227a4df0c52efaa6b5a1efbd
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Wed Sep 7 11:06:44 2011 +0100

    theoraenc: do not automatically override quality when using target bitrate
    
    If both quality and bitrate are set, libtheora will try to meet
    both constraints, causing it to prefer emitting a smaller number
    of good frames, to emitting the full number of frames that would
    not meet the requested quality. This causes a slideshow effect
    when the bitrate is low and the quality is high. And the default
    theoraenc is high (48/63).
    
    So only set quality when it is requested, and leave it unset
    otherwise.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=658443