GNOME Bugzilla – Bug 658429
fallback greeter's a11y story is not very solid anymore
Last modified: 2018-05-24 10:37:38 UTC
Here's a meta-bug collecting various issues in the new gdm session from 3.1.90. I didn't want to file many small bugs, but I can split things if needed: + data/applications/gnome-shell.desktop.in: uses /usr/bin/gnome-shell, instead of just gnome-shell. I'm not sure if this is on purpose? + data/gdm-shell.session.in: checks for mutter (to look at the version). However, gnome-shell doesn't need the mutter binary (only libmutter), so there's no guarantee that this will work. + data/applications/gok.desktop.in: gok is dead, deprecated, and everything. This should be replaced by caribou, I guess. + data/applications/gnome-mag.desktop.in: gnome-mag is as dead as gok. Maybe we should simply just consider that we have no good a11y story for gdm-fallback? + data/applications/{gok,gnome-mag,orca}.desktop.in: actually, those are useless now. Since they're not installed in a directory that is used as autostart, those files will never be looked at by gnome-session. (also, their AutostartCondition are about gconf keys) I can make patch for all of above; just tell me what's right to do :-)
> + data/applications/gnome-shell.desktop.in: uses /usr/bin/gnome-shell, instead of just gnome-shell. I'm not sure if this is on purpose? Nope not on purpose, afaik. I probably just copied the one from gnome-shell's source. > + data/gdm-shell.session.in: checks for mutter (to look at the version). However, gnome-shell doesn't need the mutter binary (only libmutter), so there's no guarantee that this will work. We can probably just drop the check, it was mainly to keep the failure experience sane in case of mismatched versions, but we can assume things will be okay for 3.2 I think. > + data/applications/gok.desktop.in: gok is dead, deprecated, and everything. > This should be replaced by caribou, I guess. > + data/applications/gnome-mag.desktop.in: gnome-mag is as dead as gok. Maybe > we should simply just consider that we have no good a11y story for > gdm-fallback? Well, it makes me a little sad to just drop it. You're right, though, the a11y story has been getting progressively worse. Not sure what to do here. I think the answer might be to fix the glaring problems and keep status quo in the mean time. > + data/applications/{gok,gnome-mag,orca}.desktop.in: actually, those are > useless now. Since they're not installed in a directory that is used as > autostart, those files will never be looked at by gnome-session. (also, their > AutostartCondition are about gconf keys) So this isn't going to work. I think I thought adding to /usr/share/gdm/greeter to XDG_DATA_DIRS and putting them in applications would be enough. but I guess would also have to make sure the desktop files were in /usr/share/gdm/greeter/autostart And like you said, settings daemon sets gsettings keys not gconf now, and also I changed gdm to run gnome-session with --failsafe to avoid unexpected autostarts now anyway. So I guess I'm going to need to do a few fixes here.
Something we could do is to make gnome-session understand Recommends in the .session files. Then you would just list orca, gok, gnome-mag, etc. as Recommends. (Recommends would not fail if the app is not present) The reason is that adding them to an autostart dir will make the gdm-shell session also start all of them, and we know we don't want gnome-mag there, for instance. Does that make sense?
yea that sounds reasonable
So i talked to Matthias about this today and he really doesn't like the Recommends idea. Basically with code freeze today, I don't think there's much we can do anyway. I also did some brief testing and caribou doesn't seem to start, so we're sort of hosed on all fronts. We'll have to revisit this post 3.2.0
(In reply to comment #0) > Here's a meta-bug collecting various issues in the new gdm session from 3.1.90. > I didn't want to file many small bugs, but I can split things if needed: > > + data/applications/gnome-shell.desktop.in: uses /usr/bin/gnome-shell, instead > of just gnome-shell. I'm not sure if this is on purpose? Fixed, as Ray said. > + data/gdm-shell.session.in: checks for mutter (to look at the version). > However, gnome-shell doesn't need the mutter binary (only libmutter), so > there's no guarantee that this will work. master has no check anymore. > + data/applications/gok.desktop.in: gok is dead, deprecated, and everything. > This should be replaced by caribou, I guess. > > + data/applications/gnome-mag.desktop.in: gnome-mag is as dead as gok. Maybe > we should simply just consider that we have no good a11y story for > gdm-fallback? Those files are gone. (I wonder if gdm can still use caribou/gnome-mag) > + data/applications/{gok,gnome-mag,orca}.desktop.in: actually, those are > useless now. Since they're not installed in a directory that is used as > autostart, those files will never be looked at by gnome-session. (also, their > AutostartCondition are about gconf keys) This is fixed now as part of bug #684474. However the fallback greeter doesn't have a way to turn orca on and off. I've reported bug #697544 for that (with a patch). Can we close this?
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gdm/issues/77.