After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658399 - Port from unique to GtkApplication
Port from unique to GtkApplication
Status: RESOLVED FIXED
Product: gnome-user-share
Classification: Core
Component: general
3.0.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-user-share maintainers
gnome-user-share maintainers
Depends on:
Blocks: 658402
 
 
Reported: 2011-09-06 21:06 UTC by Javier Jardón (IRC: jjardon)
Modified: 2012-01-11 16:39 UTC
See Also:
GNOME target: 3.4
GNOME version: 3.3/3.4

Attachments
Port from unique to GtkApplication (4.83 KB, patch)
2012-01-10 16:48 UTC, Javier Jardón (IRC: jjardon) 		reviewed Details | Review
Port from unique to GtkApplication.v2 (4.84 KB, patch)
2012-01-10 17:39 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2011-09-06 21:06:41 UTC 
http://developer.gnome.org/gtk3/stable/gtk-migrating-GtkApplication.html
Comment 1 Javier Jardón (IRC: jjardon) 2012-01-10 16:48:22 UTC 
Created attachment 204965 [details] [review]
Port from unique to GtkApplication
Comment 2 Bastien Nocera 2012-01-10 16:53:58 UTC 
Review of attachment 204965 [details] [review]:

Looks good.

::: src/file-share-properties.c
@@ +471,3 @@
 
+static GtkWidget *
+create_window ()

(void). Empty brackets means "anything goes", not nothing.

@@ +662,3 @@
+
+  if (list)
+{

coding style.
Comment 3 Javier Jardón (IRC: jjardon) 2012-01-10 17:39:20 UTC 
Created attachment 204967 [details] [review]
Port from unique to GtkApplication.v2

New patch with your comments
Comment 4 Javier Jardón (IRC: jjardon) 2012-01-11 16:38:46 UTC 
Comment on attachment 204967 [details] [review]
Port from unique to GtkApplication.v2

committed after get an ACK from Bastian on the IRC

commit 70577007a8ecce66bf6b547bda863235bc1d6f48
Comment 5 Javier Jardón (IRC: jjardon) 2012-01-11 16:39:13 UTC 
Closing. Thanks for the fast review!