After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658362 - refactor in/out marshalling to be to_py/from_py
refactor in/out marshalling to be to_py/from_py
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: introspection
unspecified
Other All
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2011-09-06 14:13 UTC by johnp
Modified: 2011-09-13 20:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
refactor in/out marshalling to be to_py/from_py (201.44 KB, patch)
2011-09-06 14:13 UTC, johnp
committed Details | Review

Description johnp 2011-09-06 14:13:04 UTC
* in/out make sense from a C perspective but when you get to the
   python layers it makes more sense to label them as to_py and
   from_py to denote which way we are marshalling
 * this helps clear up the difference between callbacks which
   call into python and invoked functions which call into C
 * in the callback case we marshal in values to Python objects
   and out values to C types but in the invoke case we do the
   reverse.  Dealing with to_py/from_py makes the code much more
   resuable and consistant
Comment 1 johnp 2011-09-06 14:13:06 UTC
Created attachment 195786 [details] [review]
refactor in/out marshalling to be to_py/from_py
Comment 2 johnp 2011-09-13 19:58:29 UTC
Maintainer's prerogative - committing this as it has been sitting here too long and is holding up my other fixes.  It is better to get this out in the wild to test.  It is also a minor change even if it touches a lot of code because it is mostly a re-factoring of function names to better fit what is actually happening during marshalling/demarshalling stages.