Steps to reproduce:

• Contact list: Chat → New Conversation…
• Enter a valid ID
• Mash enter.

Expected results:

• The “Chat” button is activated.

Actual results:

• Nothing happens.

Why?

empathy_new_message_dialog_response() uses an enum of responses:

  enum
  {
    EMP_NEW_MESSAGE_TEXT,
    EMP_NEW_MESSAGE_SMS,
  };

and ignores any responses < EMP_NEW_MESSAGE_TEXT.

Neither EmpathyNewMessageDialog nor EmpathyContactSelectorDialog (of which EmpathyNewMessageDialog is a subclass) calls gtk_dialog_set_default_response() nor gtk_widget_grab_default(). Instead, EmpathyContactSelectorDialog connects a callback to ::activate on the entry, which calls

  gtk_dialog_response (GTK_DIALOG (self), GTK_RESPONSE_ACCEPT);

GTK_RESPONSE_ACCEPT < EMP_NEW_MESSAGE_TEXT, so nothing happens.

Patch comin’ up.