Bug 658303 – Stacktrace when clicking the Close button in the Render dialog with certain project files

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 658303 - Stacktrace when clicking the Close button in the Render dialog with certain project files


Summary:	Stacktrace when clicking the Close button in the Render dialog with certain p...


Status:	RESOLVED OBSOLETE

Product:	pitivi
Classification:	Other
Component:	Rendering
Version:	Git
Hardware:	Other Linux

Importance:	Normal blocker
Target Milestone:	0.91
Assigned To:	Pitivi maintainers
QA Contact:	Pitivi maintainers

URL:
Whiteboard:

Duplicates:	658307 (view as bug list)
Depends on:
Blocks:

Reported:	2011-09-06 00:08 UTC by Alex Băluț
Modified:	2013-08-05 12:04 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
sample project file (3.18 KB, text/x-xptv) 2011-09-23 20:22 UTC, Jean-François Fortin Tam	Details
screencast (490.81 KB, video/webm) 2011-09-23 20:54 UTC, Jean-François Fortin Tam	Details

Description Alex Băluț 2011-09-06 00:08:08 UTC

Steps to reproduce:
1. Click the render button to render a project
2. Click the "DVD" render preset, or any other render preset except "HTML5 video".
3. Click the Close button, notice it does not work and a stacktrace is printed in the console. (Clicking once more the Close button closes the dialog, as expected.)

$ bin/pitivi ../tmp/Untitled2.xptv 
Traceback (most recent call last):

+ Trace 228343

File "pitivi/ui/encodingdialog.py", line 724 in _closeButtonClickedCb
```
self.destroy()
```
File "pitivi/ui/encodingdialog.py", line 755 in destroy
```
self._updateProjectSettings()
```
File "pitivi/ui/encodingdialog.py", line 752 in _updateProjectSettings
```
self.project.setSettings(settings)
```
File "pitivi/project.py", line 127 in setSettings
```
self._projectSettingsChanged()
```
File "pitivi/project.py", line 149 in _projectSettingsChanged
```
fact.setFilterCaps(self._videocaps)
```
File "pitivi/factories/base.py", line 447 in setFilterCaps
```
caps_copy = gst.Caps(caps)
```

TypeError: wrong arguments when creating GstCaps object

Comment 1 Alex Băluț 2011-09-06 00:34:59 UTC

This might be related with the fact that in the Video tab, the Codec combobox shows a value only for the "HTML5 video" render preset, and it shows no value for the others, probably because the codecs they require are not available.

Comment 2 Alex Băluț 2011-09-07 15:04:02 UTC

*** Bug 658307 has been marked as a duplicate of this bug. ***

Comment 3 Jean-François Fortin Tam 2011-09-10 20:47:10 UTC

After some testing, this has nothing to do with presets.
The way to trigger this bug on Fedora 15 is simply to have mpeg2enc as the video codec, even with "No preset". Now, the tricky part is that... it doesn't happen on Thibault's machine, so it might be a version-specific gstreamer bug.

Comment 4 Alex Băluț 2011-09-17 00:59:37 UTC

Jean, I think Thibault can reproduce the bug I described in Comment 1, which is caused by the recent render presets change.

Comment 5 Thibault Saunier 2011-09-17 13:41:09 UTC

commit 07daa6417a325e8680cdde48b9b5268d4e8ad9a4
Author: Thibault Saunier <thibault.saunier@collabora.com>
Date:   Sat Sep 10 16:49:20 2011 -0300
 
    ui: Do not show preset when some gst elements are missing

Comment 6 Jean-François Fortin Tam 2011-09-23 19:25:31 UTC

I don't see how this is fixed, with current master trying to use the DVD preset you get a crash on render and the following being printed:

**ERROR: [python] vertical_size must be a even (4:2:0)


Now, from what Thomas told me at OVC, we would need to guard against caps == None, "it can happen". If that's the case, "it's a bug because not having caps means we really cannot render".

Tip: use 
import code; code.interact(local=locals())

...to check what happens in the code

Comment 7 Jean-François Fortin Tam 2011-09-23 20:21:57 UTC

Ok turns out that what I mentionned in the last comment is actually bug 659965. However, the initial bug reported by alex in the description here still stands... if you use existing xptv files.

Comment 8 Jean-François Fortin Tam 2011-09-23 20:22:36 UTC

Created attachment 197368 [details]
sample project file

Comment 9 Jean-François Fortin Tam 2011-09-23 20:54:33 UTC

Created attachment 197375 [details]
screencast

Comment 10 Jean-François Fortin Tam 2013-08-05 12:04:31 UTC

This is so old, I have the feeling that this is is fixed nowadays...