After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658269 - opensubtitles: Use Gio introspection
opensubtitles: Use Gio introspection
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Plugins
unspecified
Other All
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on: 621915
Blocks: 626218
 
 
Reported: 2011-09-05 15:15 UTC by Bastien Nocera
Modified: 2011-09-12 14:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
opensubtitles: Use Gio introspection (2.03 KB, patch)
2011-09-05 15:15 UTC, Bastien Nocera 		needs-work Details | Review
opensubtitles: Use Gio introspection (2.15 KB, patch)
2011-09-05 15:18 UTC, Bastien Nocera 		needs-work Details | Review

Description Bastien Nocera 2011-09-05 15:15:02 UTC 
Unfinished patch.
Comment 1 Bastien Nocera 2011-09-05 15:15:04 UTC 
Created attachment 195708 [details] [review]
opensubtitles: Use Gio introspection

Instead of the static bindings, as those don't work with
libpeas.
Comment 2 Bastien Nocera 2011-09-05 15:18:22 UTC 
Created attachment 195709 [details] [review]
opensubtitles: Use Gio introspection

Instead of the static bindings, as those don't work with
libpeas.
Comment 3 Bastien Nocera 2011-09-05 15:18:45 UTC 
Comment on attachment 195709 [details] [review]
opensubtitles: Use Gio introspection

Show the FIXMEs in the right location.
Comment 4 Bastien Nocera 2011-09-12 14:29:28 UTC 
commit 9dcaa8e710db8be808e843f99dea3998b644291d
Author: Bastien Nocera <hadess@hadess.net>
Date:   Mon Sep 12 15:18:39 2011 +0100

    opensubtitles: Use Gio introspection
    
    And use Python's OS module to implement the reading
    as we won't be getting a working "read()" for Gio from
    Python any time soon (see bug #621915)
    
    https://bugzilla.gnome.org/show_bug.cgi?id=658269

commit 761bb5636c32021381de831762d475b9218a9ad9
Author: Bastien Nocera <hadess@hadess.net>
Date:   Mon Sep 12 15:17:45 2011 +0100

    opensubtitles: Fix missing GCancellable parameters
    
    Otherwise it just won't work.