After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658254 - empathy-accounts.desktop should not get installed if no control center embedding
empathy-accounts.desktop should not get installed if no control center embedding
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2011-09-05 13:23 UTC by Vincent Untz
Modified: 2011-09-06 06:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
empathy-accounts.desktop.in.in: remove X-GNOME-Settings-Panel (1.04 KB, patch)
2011-09-05 14:31 UTC, Guillaume Desmottes 		committed Details | Review

Description Vincent Untz 2011-09-05 13:23:22 UTC 
Since we can't build with the control center embedding by default (there's no header anymore), we don't have the empathy-accounts panel built.

However, empathy-accounts.desktop is still installed, which is obviously wrong.
Comment 1 Guillaume Desmottes 2011-09-05 14:11:43 UTC 
Shouldn't we continue to ship it as empathy-accounts live in its own binary and so can be used a separated app?
Comment 2 Vincent Untz 2011-09-05 14:23:27 UTC 
Oh, I completely missed the fact that it was installed as a binary too.

So then, the issue is that the current .desktop file contains the X-GNOME-Settings-Panel category while it's not a panel for g-c-c.
Comment 3 Guillaume Desmottes 2011-09-05 14:31:25 UTC 
Created attachment 195705 [details] [review]
empathy-accounts.desktop.in.in: remove X-GNOME-Settings-Panel

We can't integrate with GNOME control center any more.
Comment 4 Emilio Pozuelo Monfort 2011-09-05 14:52:16 UTC 
Comment on attachment 195705 [details] [review]
empathy-accounts.desktop.in.in: remove X-GNOME-Settings-Panel

>Subject: [PATCH] empathy-accounts.desktop.in.in: remove X-GNOME-Settings-Panel
>
>We can't integrate with GNOME control center any more.

We should also remove the control-center embedding stuff from configure.ac, src/Makefile.am and maybe other places.
Comment 5 Guillaume Desmottes 2011-09-06 05:35:44 UTC 
(In reply to comment #4)
> (From update of attachment 195705 [details] [review])
> >Subject: [PATCH] empathy-accounts.desktop.in.in: remove X-GNOME-Settings-Panel
> >
> >We can't integrate with GNOME control center any more.
> 
> We should also remove the control-center embedding stuff from configure.ac,
> src/Makefile.am and maybe other places.

Yeah that's bug #655388 but I don't think we should block on this to fix the desktop file.
Comment 6 Guillaume Desmottes 2011-09-06 06:01:43 UTC 
Attachment 195705 [details] pushed as 7936496 - empathy-accounts.desktop.in.in: remove X-GNOME-Settings-Panel