After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658236 - Explicitly link against -lm
Explicitly link against -lm
Status: RESOLVED FIXED
Product: libgnomeui
Classification: Deprecated
Component: general
unspecified
Other Linux
: Normal blocker
: future
Assigned To: libgnomeui maintainers
libgnomeui maintainers
Depends on:
Blocks:
 
 
Reported: 2011-09-05 09:28 UTC by Michael Biebl
Modified: 2011-09-08 16:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] Explicitly link against -lm (1.11 KB, patch)
2011-09-05 09:28 UTC, Michael Biebl 		none Details | Review
[PATCH] Explicitly link against -lm (1.10 KB, patch)
2011-09-05 14:49 UTC, Michael Biebl 		accepted-commit_now Details | Review

Description Michael Biebl 2011-09-05 09:28:05 UTC 
Created attachment 195674 [details] [review]
[PATCH] Explicitly link against -lm

Due to the recent changes in gdk-pixbuf [1], libgnomeui will fail to build [2]

Please find a patch attached.

[1] http://mail.gnome.org/archives/desktop-devel-list/2011-August/msg00237.html
[2] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=640455
Comment 1 Christian Persch 2011-09-05 13:45:55 UTC 
AC_CHECK_LIBM is deprecated and replaced by LT_LIB_M. With that changed, ok to commit.
Comment 2 Michael Biebl 2011-09-05 14:49:48 UTC 
Created attachment 195706 [details] [review]
[PATCH] Explicitly link against -lm

Use newer macro LT_LIB_M
Comment 3 André Klapper 2011-09-06 08:49:24 UTC 
Comment on attachment 195706 [details] [review]
[PATCH] Explicitly link against -lm

Michael: Please feel free to commit if you have git permissions.
Comment 4 Michael Biebl 2011-09-06 10:14:48 UTC 
(In reply to comment #3)
> (From update of attachment 195706 [details] [review])
> Michael: Please feel free to commit if you have git permissions.

the git push failed with:

remote: error: refname 'GNOME_0_30_MARTIN' is ambiguous
remote: A valid libgnomeui.doap file is required. See http://live.gnome.org/MaintainersCorner#maintainers
To ssh://mbiebl@git.gnome.org/git/libgnomeui
 ! [remote rejected] master -> master (pre-receive hook declined)
error: failed to push some refs to 'ssh://mbiebl@git.gnome.org/git/libgnomeui'

So I guess I need someone else to commit the patch.
Comment 5 Christian Persch 2011-09-08 11:51:21 UTC 
DOAP file added, you should be able to push now.
Comment 6 Michael Biebl 2011-09-08 16:04:25 UTC 
Pushed(In reply to comment #5)
> DOAP file added, you should be able to push now.

Pushed