After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658122 - Caps_Lock should not be toggled when Orca commands are used in laptop layout
Caps_Lock should not be toggled when Orca commands are used in laptop layout
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Orca Maintainers
Orca Maintainers
: 661844 (view as bug list)
Depends on: 658121
Blocks:
 
 
Reported: 2011-09-03 14:01 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2011-11-23 12:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
A tested patch with Bill doed (4.43 KB, patch)
2011-11-18 14:54 UTC, Hammer Attila 		none Details | Review

Description Joanmarie Diggs (IRC: joanie) 2011-09-03 14:01:29 UTC 
In the laptop layout, the Caps Lock key is the traditional "Orca Modifier" key. As such, using Orca commands should not cause the state of the Caps_Lock key to be toggled. Recently however, this has been broken ... somewhere.

See bug 658121 (filed against AT-SPI2 at the moment) in which this problem can be reproduced without Orca.
Comment 1 Joanmarie Diggs (IRC: joanie) 2011-10-15 17:40:41 UTC 
*** Bug 661844 has been marked as a duplicate of this bug. ***
Comment 2 Hammer Attila 2011-11-18 14:54:36 UTC 
Created attachment 201670 [details] [review]
A tested patch with Bill doed

Hy Joanie,

I attaching Bill doed patch, please look.
I tested this patch in Ubuntu Oneiric with Orca master version.
The patch works correct my system, Orca doesn't producing the described issue. The caps lock key state doesn't change if I activating any laptop binding command for Orca, but caps lock state change is possible of course if I using Orca modifier+Backspace keystroke before press caps lock key again.

Attila
Comment 3 waywardgeek@gmail.com 2011-11-19 20:46:51 UTC 
Thans, Attila, for creating the patch and attaching it here.  This is the patch I recommend for the near term for Orca, as it should work with all the system orca is on now, without requiring any changes to any other packages.  In the meantime, I'll try to get the new caps lock mode upstream.
Comment 4 Joanmarie Diggs (IRC: joanie) 2011-11-23 12:32:15 UTC 
(In reply to comment #3)
> Thans, Attila, for creating the patch and attaching it here.  This is the patch
> I recommend for the near term for Orca, as it should work with all the system
> orca is on now, without requiring any changes to any other packages.  In the
> meantime, I'll try to get the new caps lock mode upstream.

Awesome Bill. Thanks! It works for me, so I've committed it to master where it can get some additional testing from users. Based on that (along with some testing I want to do with it in OpenIndiana) I'll make a decision about committing it to our other branches.