After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658104 - GDateTime test case locale problems
GDateTime test case locale problems
Status: VERIFIED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2011-09-03 01:27 UTC by Allison Karlitskaya (desrt)
Modified: 2011-09-03 04:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gdatetime: Fix locale-changing code (1.44 KB, patch)
2011-09-03 03:37 UTC, Matthias Clasen
committed Details | Review

Description Allison Karlitskaya (desrt) 2011-09-03 01:27:16 UTC
http://git.gnome.org/browse/glib/commit/?id=17d8d2cc44af8b6b656cc971e68d71115acb7e8c

This commit adds a GDateTime testcase that switches the locale to fa_IR.UTF-8 for purpose of testing the alternate numeric forms.  The code to switch the locale back to its old value appears to be broken, though.  Any testcase using number formatting that runs after this one breaks.

I worked around this issue by moving my strftime test case to just above the modifiers case, but it should probably be fixed properly.
Comment 1 Matthias Clasen 2011-09-03 03:37:36 UTC
The following fix has been pushed:
f091c6a gdatetime: Fix locale-changing code
Comment 2 Matthias Clasen 2011-09-03 03:37:39 UTC
Created attachment 195554 [details] [review]
gdatetime: Fix locale-changing code

As pointed out by Ryan Lortie, the code didn't actually ever
switch back to the old locale.
Comment 3 Allison Karlitskaya (desrt) 2011-09-03 04:33:37 UTC
works fine now, thanks.