After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658085 - Update help buttons and menus
Update help buttons and menus
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
0.x.x [obsolete]
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-09-02 18:20 UTC by Shaun McCance
Modified: 2011-09-05 14:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Update help targets and add more useful entries to help buttons and menu (9.84 KB, patch)
2011-09-02 18:20 UTC, Shaun McCance
needs-work Details | Review
Updated patch per Cosimo's review (9.89 KB, patch)
2011-09-02 20:43 UTC, Shaun McCance
committed Details | Review

Description Shaun McCance 2011-09-02 18:20:40 UTC
Created attachment 195518 [details] [review]
Update help targets and add more useful entries to help buttons and menu

The desktop help has moved to the new proposed XDG help system, so the help URIs in Nautilus need to be updated. I'm attaching a patch that improves the help buttons and menu. I've made the tabs in the file properties dialog launch an appropriate help page (like the tabs in the preefs dialog do). And I've replaced "Contents" in the menu (ugh) with a short list of topics, plus "All Topics".
Comment 1 Cosimo Cecchi 2011-09-02 18:44:23 UTC
Review of attachment 195518 [details] [review]:

Thanks for the patch, a few minor comments.

::: src/nautilus-properties-window.c
@@ +2361,3 @@
 	gtk_box_set_spacing (GTK_BOX (hbox), 12);
 	gtk_notebook_append_page (notebook, hbox, gtk_label_new (title));
+	g_object_set_data (G_OBJECT (hbox), "help-uri", (gpointer) help_uri);

Don't you need to strdup help_uri here and in the cases below? You can use g_object_set_data_full() for it.

@@ +5164,3 @@
+	NautilusPropertiesWindow *window = NAUTILUS_PROPERTIES_WINDOW (dialog);
+	GtkWidget *curpage;
+	gchar *helpuri;

Should be const char *

::: src/nautilus-window-menus.c
@@ +423,3 @@
 	GError *error;
 	GtkWidget *dialog;
+	char* helpuri;

Should be const char *

@@ +431,3 @@
+	if (g_str_equal (name, "NautilusHelpSearch")) {
+		helpuri = "help:gnome-help/files-search";
+	}

Coding style, should be

if (cond1) {

} else if (cond2) {

}
Comment 2 Shaun McCance 2011-09-02 20:43:08 UTC
Created attachment 195533 [details] [review]
Updated patch per Cosimo's review
Comment 3 Cosimo Cecchi 2011-09-03 02:46:11 UTC
Review of attachment 195533 [details] [review]:

Looks good.
Comment 4 Shaun McCance 2011-09-05 14:08:45 UTC
Got r-t approval for the UI change. Pushed to master and notified gnome-i18n of the new strings.