GNOME Bugzilla – Bug 658085
Update help buttons and menus
Last modified: 2011-09-05 14:08:58 UTC
Created attachment 195518 [details] [review] Update help targets and add more useful entries to help buttons and menu The desktop help has moved to the new proposed XDG help system, so the help URIs in Nautilus need to be updated. I'm attaching a patch that improves the help buttons and menu. I've made the tabs in the file properties dialog launch an appropriate help page (like the tabs in the preefs dialog do). And I've replaced "Contents" in the menu (ugh) with a short list of topics, plus "All Topics".
Review of attachment 195518 [details] [review]: Thanks for the patch, a few minor comments. ::: src/nautilus-properties-window.c @@ +2361,3 @@ gtk_box_set_spacing (GTK_BOX (hbox), 12); gtk_notebook_append_page (notebook, hbox, gtk_label_new (title)); + g_object_set_data (G_OBJECT (hbox), "help-uri", (gpointer) help_uri); Don't you need to strdup help_uri here and in the cases below? You can use g_object_set_data_full() for it. @@ +5164,3 @@ + NautilusPropertiesWindow *window = NAUTILUS_PROPERTIES_WINDOW (dialog); + GtkWidget *curpage; + gchar *helpuri; Should be const char * ::: src/nautilus-window-menus.c @@ +423,3 @@ GError *error; GtkWidget *dialog; + char* helpuri; Should be const char * @@ +431,3 @@ + if (g_str_equal (name, "NautilusHelpSearch")) { + helpuri = "help:gnome-help/files-search"; + } Coding style, should be if (cond1) { } else if (cond2) { }
Created attachment 195533 [details] [review] Updated patch per Cosimo's review
Review of attachment 195533 [details] [review]: Looks good.
Got r-t approval for the UI change. Pushed to master and notified gnome-i18n of the new strings.