After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658076 - setcaps function for ghost pads never called
setcaps function for ghost pads never called
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
0.10.31
Other Linux
: Normal normal
: 0.10.36
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-09-02 16:54 UTC by Stas Sergeev
Modified: 2011-09-07 16:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
potential fix (1.73 KB, patch)
2011-09-02 16:54 UTC, Stas Sergeev 		committed Details | Review

Description Stas Sergeev 2011-09-02 16:54:28 UTC 
Created attachment 195506 [details] [review]
potential fix

Hi.

Currently the setcaps function set for the ghostpad, is never called.
I am not yet sure whether this is a bug or a design decision, so I
posted a query:
http://lists.freedesktop.org/archives/gstreamer-devel/2011-September/033018.html

But here's the fix anyway.
Comment 1 Sebastian Dröge (slomo) 2011-09-07 11:39:08 UTC 
commit fcadf09779f7c7f1856dccca90ddae8ac5c72b9e
Author: Stas Sergeev <stas@stas.(none)>
Date:   Fri Sep 2 19:46:06 2011 +0400

    ghostpad: Use gst_pad_set_caps() instead of manually changing caps
    
    gst_pad_set_caps() does essentially the same but additionally calls
    the pad's setcaps function.
    
    Fixes bug #658076.
Comment 2 Tim-Philipp Müller 2011-09-07 11:53:38 UTC 
> Author: Stas Sergeev <stas@stas.(none)>

PS: for future patches, could you please change your git config to a proper e-mail address? Thanks!
Comment 3 Stas Sergeev 2011-09-07 16:29:37 UTC 
Sure, will do.
Thanks for committing the patch.