After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658063 - caribou-gtk-module: don't add the event filter until the dbus call finishes
caribou-gtk-module: don't add the event filter until the dbus call finishes
Status: RESOLVED FIXED
Product: caribou
Classification: Applications
Component: default
git master
Other All
: Normal normal
: ---
Assigned To: caribou-maint
caribou-maint
Depends on:
Blocks:
 
 
Reported: 2011-09-02 15:18 UTC by Dan Winship
Modified: 2011-09-15 16:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
caribou-gtk-module: don't add the event filter until the dbus call finishes (1.83 KB, patch)
2011-09-02 15:18 UTC, Dan Winship
committed Details | Review

Description Dan Winship 2011-09-02 15:18:47 UTC
event_filter() assumes that the D-Bus handle to the keyboard has been
initialized (and will crash if it's null), so don't set up the event
filter until after the async call returns.
Comment 1 Dan Winship 2011-09-02 15:18:49 UTC
Created attachment 195489 [details] [review]
caribou-gtk-module: don't add the event filter until the dbus call finishes
Comment 2 Dan Winship 2011-09-15 12:37:56 UTC
poke? can this go in?

(i think bz may have been dropping mail for a few days when I originally posted this, so you might not have seen it...)
Comment 3 Eitan Isaacson 2011-09-15 15:06:58 UTC
Comment on attachment 195489 [details] [review]
caribou-gtk-module: don't add the event filter until the dbus call finishes

Sorry, didnt see this. Looks great.
Comment 4 Dan Winship 2011-09-15 16:36:11 UTC
Attachment 195489 [details] pushed as ae678cf - caribou-gtk-module: don't add the event filter until the dbus call finishes