GNOME Bugzilla – Bug 658049
"Connection lost" notification should be closed after reconnecting
Last modified: 2011-09-24 06:20:44 UTC
The "Connection lost" notification is marked as urgent, which means that it will stay around until acknowledged. While the urgency is justified in my opinion, it should be closed automatically after a reconnection attempt has succeeded.
As a sidenote, it feels very odd to me to click on this notification to make it go away - I expect clicking on the notification to bring up network settings or something. I don't know if an X in the corner would improve things (make it obvious that you can close this without needing to do anything), or make it worse (everybody will thing they need to navigate to a little X) Basically, I'm not convinced it should be urgent at all. It's not telling me that I need to _do_ anything. But then again, I _am_ almost always connected to a new network by the time I see it, so perhaps simply closing it on reconnection works.
(In reply to comment #1) > As a sidenote, it feels very odd to me to click on this notification to make it > go away - I expect clicking on the notification to bring up network settings or > something. That would be doable with a default action, and probably a good idea anyway - I recall some conversations with designers about the inconsistent behavior when clicking a notification; there was some traction to the idea that we should always present a window in that case.
*** Bug 658233 has been marked as a duplicate of this bug. ***
Created attachment 195683 [details] [review] Network: destroy notifications when the connection completes When you finish reconnecting, we should remove any Connection Lost or Connection Failed notification.
Review of attachment 195683 [details] [review]: ::: js/ui/status/network.js @@ +1876,3 @@ + if (a.state == NetworkManager.ActiveConnectionState.ACTIVATED + && a._primaryDevice && a._primaryDevice._notification) + a._primaryDevice._notification.destroy(); Should also "delete activeConnection._primaryDevice._notification" right? @@ +1886,3 @@ + if (activeConnection.state == NetworkManager.ActiveConnectionState.ACTIVATED + && activeConnection._primaryDevice && activeConnection._primaryDevice._notification) + activeConnection._primaryDevice._notification.destroy(); Ditto?
*** Bug 658621 has been marked as a duplicate of this bug. ***
Created attachment 196080 [details] [review] Network: destroy notifications when the connection completes When you finish reconnecting, we should remove any Connection Lost or Connection Failed notification. Apparently, I forgot to attach the updated patch.
Review of attachment 196080 [details] [review]: Looks OK.
By the way, are these notifications in the design, or are they just ported over from GNOME 2 basically? (I find them pretty worthless personally...evolution and firefox both actively watch NM state, and if stuff breaks I know to look at the network icon anyways)
Furthermore, when I always see them is after resume from suspend, which (generally) involves location move, so network being dropped is expected.
They also stack, which is an incredible nuisance. Using network manager with a usb tether or mobile broadband is already painful enough with the constant disconnects. In a typical hour it can often disconnect as many as 20 or 30 times... if you have stepped away for that hour to take care of something else you now have 20 or 30 of these notifications stacked on top of each other... they must all be clicked one at a time before you have access to anything in the notification area.
Attachment 196080 [details] pushed as 7b1deba - Network: destroy notifications when the connection completes @bluewanders: notifications should not stack, there should be at most one for each network device. File a new bug if this happens.
*** Bug 658954 has been marked as a duplicate of this bug. ***
Still happening when changing from a wired connection in the office to a wireless one at home :(
(In reply to comment #14) > Still happening when changing from a wired connection in the office to a > wireless one at home :( This is expected: the wired and wireless connections are on different devices, so they have independent notifications. I made this for the case when you have more than one device active at the same time (like ethernet + adhoc wireless). Is this common enough or it is better to fix the "moving laptop" situation?
(In reply to comment #15) > This is expected: the wired and wireless connections are on different devices, > so they have independent notifications. Yes, I can tell that from the code. However as user, the message says "You are no longer connected to the network", so I would not expect any active network connection when seeing it. > I made this for the case when you have more than one device active at the same > time (like ethernet + adhoc wireless). > Is this common enough or it is better to fix the "moving laptop" situation? Depending on the resolution of bug 658954, the fix may not be needed :)
The notification in question was removed, so this is no longer an issue.
Well, that particualar notification was removed, but previously I fist had a "Connection Lost" and when I clicked on that it went away and I got a "Network Disconnected" that I had to click. Now with gnome 3.2.92, the "Connection Lost" is destroyed correctly but the "Netwwork Disconnected" is still there until I click on it.