After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658011 - datetime: Use GnomeWallClock instead of periodic timeout
datetime: Use GnomeWallClock instead of periodic timeout
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Date and Time
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on: 657955
Blocks:
 
 
Reported: 2011-09-01 20:36 UTC by Colin Walters
Modified: 2011-09-21 14:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
datetime: Use GnomeWallClock instead of periodic timeout (4.85 KB, patch)
2011-09-01 20:36 UTC, Colin Walters 		committed Details | Review

Description Colin Walters 2011-09-01 20:36:14 UTC 
We don't actually use the ::clock property string here - this
is just making it so we don't need to wake up once a second.
Comment 1 Colin Walters 2011-09-01 20:36:16 UTC 
Created attachment 195441 [details] [review]
datetime: Use GnomeWallClock instead of periodic timeout
Comment 2 Javier Jardón (IRC: jjardon) 2011-09-05 11:52:55 UTC 
Review of attachment 195441 [details] [review]:

A little coment about gnome-desktop required version

::: configure.ac
@@ +94,3 @@
                   gdk-pixbuf-2.0 >= $GDKPIXBUF_REQUIRED_VERSION)
 PKG_CHECK_MODULES(DATETIME_PANEL, $COMMON_MODULES dbus-glib-1
+		  gnome-desktop-3.0 >= 3.1.0

The gnome-desktop required version is 3.1.91
Comment 3 Bastien Nocera 2011-09-05 12:46:45 UTC 
Review of attachment 195441 [details] [review]:

Apart from the 2 comments below, it's fine by me, but only for master (not gnome-3-2).

::: panels/datetime/cc-datetime-panel.c
@@ +36,3 @@
+#include "cc-timezone-map.h"
+#include "dtm.h"
+#include "date-endian.h"

Any reasons you're doing headers re-ordering here? Please don't.
Comment 4 Colin Walters 2011-09-08 17:00:06 UTC 
(In reply to comment #3)
> Review of attachment 195441 [details] [review]:
> 
> Apart from the 2 comments below, it's fine by me, but only for master (not
> gnome-3-2).

Okay.

> ::: panels/datetime/cc-datetime-panel.c
> @@ +36,3 @@
> +#include "cc-timezone-map.h"
> +#include "dtm.h"
> +#include "date-endian.h"
> 
> Any reasons you're doing headers re-ordering here? Please don't.

I always do:

config.h

header-for-this-file.h

system headers (string.h)

gnome headers
Comment 5 Bastien Nocera 2011-09-08 17:09:44 UTC 
(In reply to comment #4)
> > Any reasons you're doing headers re-ordering here? Please don't.
> 
> I always do:
> 
> config.h
> 
> header-for-this-file.h
> 
> system headers (string.h)
> 
> gnome headers

Make that a separate patch if you must.
Comment 6 Javier Jardón (IRC: jjardon) 2011-09-20 23:03:33 UTC 
Comment on attachment 195441 [details] [review]
datetime: Use GnomeWallClock instead of periodic timeout

commited with your comments on commit f708c36fc32db4b54aa2509ea7334a721fd3478a
Comment 7 Javier Jardón (IRC: jjardon) 2011-09-20 23:05:04 UTC 
Any chance to get this in gnome-3-2 branch? Seems to work fine and also the patch can save some battery as we dont have to wake up every minute
Comment 8 André Klapper 2011-09-21 02:47:59 UTC 
(In reply to comment #7)
> Any chance to get this in gnome-3-2 branch?

Note that we are under hardcode freeze.
Comment 9 Colin Walters 2011-09-21 13:57:05 UTC 
(In reply to comment #7)
> Any chance to get this in gnome-3-2 branch? Seems to work fine and also the
> patch can save some battery as we dont have to wake up every minute

Note "most" people probably don't leave the control center open, so it's not a big deal.
Comment 10 Bastien Nocera 2011-09-21 14:02:02 UTC 
Definitely something for 3.4.