GNOME Bugzilla – Bug 658008
Centered text alignment in GtkAssistant is wrong
Last modified: 2011-09-04 04:42:57 UTC
The GtkAssistant in GTK+3 has text in the list of stages in GtkAssistant centered (see attached screenshot). According to Richard Hughes of GNOME Color Manager fame this is a design decision. If it is, then pretty please revisit this decision. Centered text in lists is really bad design.
Created attachment 195440 [details] screenshot to illustrate the issue
I agree with Alexandre. Not only is it harder to read, it draws away attention from the page.
Hylke, don't play with the bugzilla fields :-p NEEDINFO is for maintainers to set to ask additional information to the reporter. the critical is generally for crashers.
since it's a UI design issue, let's add the ui-review keyword
(In reply to comment #3) > Hylke, don't play with the bugzilla fields :-p > > NEEDINFO is for maintainers to set to ask additional information to the > reporter. > > the critical is generally for crashers. I did not realise I changed anything. Sorry in that case.
Created attachment 195486 [details] [review] assistant: Don't center page names
And it doesn't need ui-review, we already got it in comment 2.
Review of attachment 195486 [details] [review]: GtkMisc is obsolescent. Please use GtkWidget::halign
(In reply to comment #8) > Review of attachment 195486 [details] [review]: > > GtkMisc is obsolescent. Please use GtkWidget::halign In which case the patch isn't right, and GtkWidget::halign is broken, seeing as it's already set: http://git.gnome.org/browse/gtk+/tree/gtk/gtkassistant.c#n1613
Sorry, I was wrong here.
The following fix has been pushed: 41dbd20 GtkAssistant: Fix label alignment
Created attachment 195609 [details] [review] GtkAssistant: Fix label alignment Make page titles left-aligned again. Changing from misc alignment to GtkWidget::halign here was a mistake. We can't do that for labels in a size group, as long as labels still pay attention to misc alignment.