After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 658004 - hotplug, remove the icon at the side of "Removable Devices" inside the bubble
hotplug, remove the icon at the side of "Removable Devices" inside the bubble
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-09-01 19:58 UTC by Lapo Calamandrei
Modified: 2011-09-20 00:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
autorun: don't use a custom size for the hotplug icon (2.29 KB, patch)
2011-09-19 21:49 UTC, Cosimo Cecchi 		committed Details | Review

Description Lapo Calamandrei 2011-09-01 19:58:54 UTC 
The icon there is basically the same thing shown some pixel below it (messaging tray), I think it's cleaner w/o it.
Comment 1 Cosimo Cecchi 2011-09-01 21:57:17 UTC 
Turns out the message tray icon should be a bit bigger as well. I think right now we use a 16px icon, but it should be 24px instead.
Comment 2 Cosimo Cecchi 2011-09-19 21:49:33 UTC 
Created attachment 197005 [details] [review]
autorun: don't use a custom size for the hotplug icon

Instead, just use the default MessageTray.Source icon size (24px).
Comment 3 Rui Matos 2011-09-19 22:32:15 UTC 
Review of attachment 197005 [details] [review]:

Tested. Code looks good.
Comment 4 Cosimo Cecchi 2011-09-20 00:54:52 UTC 
Attachment 197005 [details] pushed as 3ebf6e3 - autorun: don't use a custom size for the hotplug icon

Thanks, pushed to master.