After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 657989 - Use g_format_get_size()
Use g_format_get_size()
Status: RESOLVED FIXED
Product: brasero
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Brasero maintainer(s)
Brasero maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-09-01 18:31 UTC by Cosimo Cecchi
Modified: 2011-09-02 19:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
all: switch to g_format_size() (6.20 KB, patch)
2011-09-01 18:31 UTC, Cosimo Cecchi 		committed Details | Review
build: fix a build warning (1001 bytes, patch)
2011-09-01 18:31 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2011-09-01 18:31:40 UTC 
g_format_size_for_display() has been deprecated by g_format_size(), replace its use.
Comment 1 Cosimo Cecchi 2011-09-01 18:31:42 UTC 
Created attachment 195425 [details] [review]
all: switch to g_format_size()

Instead of the deprecated g_format_size_for_display()
Comment 2 Cosimo Cecchi 2011-09-01 18:31:44 UTC 
Created attachment 195426 [details] [review]
build: fix a build warning
Comment 3 Luis Medinas 2011-09-01 18:53:12 UTC 
glib needs to be bumped ?
Comment 4 Cosimo Cecchi 2011-09-01 23:40:50 UTC 
Yeah, forgot about bumping it. I can do it while committing if the patch is good for you otherwise.
Comment 5 Luis Medinas 2011-09-02 09:04:46 UTC 
Please commit.
Comment 6 André Klapper 2011-09-02 15:16:03 UTC 
[Using patch status flags welcome so patches accepted for commit can actually be queried for.]
Comment 7 Luis Medinas 2011-09-02 15:18:55 UTC 
Review of attachment 195426 [details] [review]:

Looks good
Comment 8 Luis Medinas 2011-09-02 15:19:18 UTC 
Review of attachment 195425 [details] [review]:

Looks good
Comment 9 Cosimo Cecchi 2011-09-02 19:08:52 UTC 
Attachment 195425 [details] pushed as 0f13732 - all: switch to g_format_size()
Attachment 195426 [details] pushed as 7e3d117 - build: fix a build warning

Thanks, pushed to master.