After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 657975 - Support undo of delete
Support undo of delete
Status: RESOLVED FIXED
Product: gnome-contacts
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Contacts maintainer(s)
GNOME Contacts maintainer(s)
: 659746 666534 (view as bug list)
Depends on: 657974
Blocks:
 
 
Reported: 2011-09-01 17:39 UTC by Alexander Larsson
Modified: 2011-12-19 15:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
The patch, as stated in Gnome Submitting patches. Well commented inside (27.15 KB, patch)
2011-12-19 13:11 UTC, Erick Perez Castellanos
none Details | Review

Description Alexander Larsson 2011-09-01 17:39:20 UTC
Allan has a mockup somewhere.

We can support this by making a local copy of the pre-delete data, but ideally we should get some support from folks for this. See bug 657974.
Comment 1 Erick Perez Castellanos 2011-12-19 13:11:34 UTC
Created attachment 203864 [details] [review]
The patch, as stated in Gnome Submitting patches. Well commented inside
Comment 2 Erick Perez Castellanos 2011-12-19 13:12:43 UTC
Here it goes a patch for solving this. It has been talked with the developers, and has implemented in-app notifications.
Comment 3 Erick Perez Castellanos 2011-12-19 13:46:36 UTC
*** Bug 659746 has been marked as a duplicate of this bug. ***
Comment 4 Alexander Larsson 2011-12-19 14:39:16 UTC
I commited this patch with some minor changes like:

* Ported to master
* Fixed up whitespace in the files (space at end of lines, etc)
* Fixed a bunch of indentation issues (like space before parantesis, no brackes for one line if, etc
* No need to check twice for _is_hidden_to_delete in is_hidden
* Nicer label in the delete notification

There are still some issues though, that i'd like to clean up:

* We shouldn't be using the Gtk namespace in our app, that is just asking for problem when similar api appears in Gtk.
* The indentation in gtk-notification.c isn't typical gtk+ style
* I think the shadow can be made nicer, for instance there should not be rounded borders at the top, it should go up all the way to the window border
* We don't want to load a custom CSS snippet for the widget, but rather rely on Adwaita and other themes to get our default look
* We want to animate the notifications
* We want to handle stacking of notifications better, they should not cover each other
* "actioned" isn't a great name
Comment 5 Allan Day 2011-12-19 15:18:05 UTC
*** Bug 666534 has been marked as a duplicate of this bug. ***