After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 657926 - add per-source icon
add per-source icon
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: core
git master
Other Linux
: Normal enhancement
: ---
Assigned To: grilo-maint
grilo-maint
: 487973 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-09-01 12:51 UTC by Jonathan Matthew
Modified: 2014-01-16 20:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
core: Add Icon property to GrlSource (3.70 KB, patch)
2013-12-19 22:00 UTC, Bastien Nocera 		none Details | Review
core: Add Icon property to GrlSource (3.69 KB, patch)
2013-12-19 22:46 UTC, Bastien Nocera 		committed Details | Review

Description Jonathan Matthew 2011-09-01 12:51:02 UTC 
I'm writing a rhythmbox plugin using grilo, and I'd like to have icons to display next to each grilo source in the source list.  For most sources this would be the site logo, and for upnp, the url returned by gupnp_device_info_get_icon_url would work.  All I'd really expect grilo to do here would be to provide access to the url.
Comment 1 Jonathan Matthew 2011-09-11 09:57:03 UTC 
*** Bug 487973 has been marked as a duplicate of this bug. ***
Comment 2 Bastien Nocera 2012-03-27 15:21:06 UTC 
This would also be nice to have in Totem.
Comment 3 Bastien Nocera 2013-12-19 22:00:09 UTC 
Created attachment 264576 [details] [review]
core: Add Icon property to GrlSource
Comment 4 Bastien Nocera 2013-12-19 22:46:08 UTC 
Created attachment 264582 [details] [review]
core: Add Icon property to GrlSource
Comment 5 Juan A. Suarez Romero 2014-01-16 20:15:03 UTC 
I've slightly changed the commit to include the new method in the documentation.

commit c8423dac910f41670754b0c18041854bcd64551d
Author: Bastien Nocera <hadess@hadess.net>
Date:   Thu Dec 19 22:44:09 2013 +0100

    core: Add Icon property to GrlSource
    
    https://bugzilla.gnome.org/show_bug.cgi?id=657926
    
    Signed-off-by: Bastien Nocera <hadess@hadess.net>
    Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com>

 doc/grilo/grilo-sections.txt |  1 +
 src/grl-source.c             | 40 ++++++++++++++++++++++++++++++++++++++++
 src/grl-source.h             |  3 +++
 3 files changed, 44 insertions(+)