Bug 657871 – Patch to only update the MIME database if DESTDIR is not set

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 657871 - Patch to only update the MIME database if DESTDIR is not set


Summary:	Patch to only update the MIME database if DESTDIR is not set


Status:	RESOLVED FIXED

Product:	gcr
Classification:	Core
Component:	General
Version:	3.1.x
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	GNOME keyring maintainer(s)
QA Contact:	GNOME keyring maintainer(s)

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2011-08-31 21:00 UTC by Kalev Lember
Modified:	2019-02-22 11:58 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
gcr: Only update the MIME database if DESTDIR is not set (2.14 KB, patch) 2011-08-31 21:00 UTC, Kalev Lember	none	Details \| Review
[v2] gcr: Don't update the MIME database if DESTDIR is set (2.22 KB, patch) 2011-09-03 15:56 UTC, Kalev Lember	none	Details \| Review

Description Kalev Lember 2011-08-31 21:00:56 UTC

Created attachment 195351 [details] [review]
gcr: Only update the MIME database if DESTDIR is not set

Instead of making all distros use --disable-update-mime, it's better to just check if DESTDIR is set and avoid updating the MIME database in that case. The attached patch implements this.

Also, while at that, fixed it so that update-mime-database is actually called _after_ the .xml file gets installed.

Comment 1 Stef Walter 2011-09-03 11:26:23 UTC

Have you tested this with 'make distcheck'?

Comment 2 Kalev Lember 2011-09-03 15:56:12 UTC

Created attachment 195581 [details] [review]
[v2] gcr: Don't update the MIME database if DESTDIR is set

Updated the patch to fix 'make distcheck' errors.

Comment 3 Stef Walter 2011-09-05 05:32:33 UTC

Thanks! Kept configure.ac as it was before this patch, no need to change it. Merged.

Comment 4 Kalev Lember 2011-09-05 09:27:12 UTC

Thanks!

The reason for the configure.ac change was to get the 
  echo "*** MIME database not updated.  After (un)install, run this:"; \
  echo "***   $(update_mime_database_cmd)"; \
message even when --disable-update-mime is used.

But works this way too.

Comment 5 Stef Walter 2011-09-06 13:35:13 UTC

That's true. I missed that. Although if it is explicitly disabled, we could assume that the packager/builder is aware of what was done.