After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 657842 - Search field isn't at the right end of the History window toolbar
Search field isn't at the right end of the History window toolbar
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Archives
3.1.x
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
Depends on: 657841 657843
Blocks:
 
 
Reported: 2011-08-31 17:25 UTC by Matthew Paul Thomas (mpt)
Modified: 2011-09-02 14:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot (31.48 KB, image/png)
2011-08-31 17:25 UTC, Matthew Paul Thomas (mpt)
  Details
log-window: expand the search widget (979 bytes, patch)
2011-09-01 13:34 UTC, Guillaume Desmottes
rejected Details | Review
log-window: align the account chooser and search widget (2.12 KB, patch)
2011-09-01 14:03 UTC, Guillaume Desmottes
committed Details | Review

Description Matthew Paul Thomas (mpt) 2011-08-31 17:25:18 UTC
Created attachment 195329 [details]
screenshot

Empathy 3.1.5.1, Ubuntu Ocelot

In the History window toolbar, the "Show" and "Search" controls are immediately to the right of the "Profile", "Chat", "Call", and "Video" toolbar buttons. Depending on the window size, this leaves a large gap at the right end of the toolbar.

As shown in the wireframe <http://bugzilla-attachments.gnome.org/attachment.cgi?id=183091>, the search field should be aligned to the right of the toolbar (like it is in Firefox, Epiphany, etc), and the account menu should be centered.
Comment 1 Guillaume Desmottes 2011-09-01 13:34:18 UTC
Created attachment 195385 [details] [review]
log-window: expand the search widget

That it's aligned to the right of the toolbar and so we don't waste space.
Comment 2 Emilio Pozuelo Monfort 2011-09-01 13:51:20 UTC
Comment on attachment 195385 [details] [review]
log-window: expand the search widget

>Subject: [PATCH] log-window: expand the search widget

That's not what we need to do. We should add an empty tool item that is expanded, so that the search entry is moved to the end. I'm not sure how we can center the account chooser though. Perhaps having two empty items that are expand=TRUE and homogeneous=TRUE ?
Comment 3 Guillaume Desmottes 2011-09-01 14:03:56 UTC
Created attachment 195386 [details] [review]
log-window: align the account chooser and search widget

Center the account chooser and align the search widget to the right of the
toolbar.
Comment 4 Emilio Pozuelo Monfort 2011-09-01 14:15:21 UTC
Comment on attachment 195386 [details] [review]
log-window: align the account chooser and search widget

++
Comment 5 Guillaume Desmottes 2011-09-01 14:21:27 UTC
I asked for an UI exception.
Comment 6 Guillaume Desmottes 2011-09-02 14:07:49 UTC
Attachment 195386 [details] pushed as 24bc9e5 - log-window: align the account chooser and search widget