GNOME Bugzilla – Bug 657810
Allow to flip orientation for left handed people
Last modified: 2011-09-06 20:38:06 UTC
Some models* feature hardware buttons on the side and allow to rotate the hardware 180° for left handed people. Unless rotated, left handed people will accidentally hit the hardware buttons. I have updated the design** to add a control for the models where this applies. Just like with the case of the 'calibrate' button, this should not be shown for the majority models where this doesn't apply. This is a show stopper for left handers with certain models of tablets, but the design did come late, so I'm not sure about targeting 3.2 * http://www.designophy.com/uploadedimages/tmn/2009/04/05/designophy_com_a1_1000001536_102.jpg ** https://live.gnome.org/Design/SystemSettings/Tablet
Created attachment 195362 [details] [review] Add a rotation radiobutton Notes: As per design, only left/right-handed is shown. if the user preconfigured cw/ccw, the right-handed button is selected but doesn't modify the gsettings value. I tried with an invisible radio button for this case but that didn't work. Design suggests to only show this for tablets with buttons on one side. that's the vast majority and we don't have a good database for which tablets this affects. For future patches, if we implement actual rotation (e.g. for built-in tablets) this will have to be synchronised so that rotation + left-handed has some defined meaning.
Review of attachment 195362 [details] [review]: As mentioned on IRC, instead of 2 radio buttons we should have a: Left-handed [ ON | OFF ] GtkSwitch instead.
Can we change the terms a bit? A think something like "Left-handed orientation [ ON | OFF ]" is clearer because it says what it affects.
(In reply to comment #3) > Can we change the terms a bit? > A think something like "Left-handed orientation [ ON | OFF ]" is clearer > because it says what it affects. I'm fine with it if Peter thinks it's a good fit.
Created attachment 195446 [details] [review] Add a left-handed switch not sure if the label is supposed to be dim or not here, the radio buttons weren't so I left this one black too
Review of attachment 195446 [details] [review]: ::: panels/wacom/gnome-wacom-properties.ui @@ +226,3 @@ + <property name="visible">True</property> + <property name="can_focus">False</property> + <property name="label">Left-Handed Orientation:</property> If I read this correctly this label should be marked for translation.
(In reply to comment #6) > Review of attachment 195446 [details] [review]: > > ::: panels/wacom/gnome-wacom-properties.ui > @@ +226,3 @@ > + <property name="visible">True</property> > + <property name="can_focus">False</property> > + <property name="label">Left-Handed Orientation:</property> > > If I read this correctly this label should be marked for translation. Will fix before committing, thanks.
Comment on attachment 195446 [details] [review] Add a left-handed switch Pushed to master
Pushed to gnome-3-2 as well.