After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 657773 - Refine the idle material state in EOS
Refine the idle material state in EOS
Status: RESOLVED FIXED
Product: clutter-gst
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: clutter-gst-maint
clutter-gst-maint
Depends on:
Blocks:
 
 
Reported: 2011-08-30 23:46 UTC by Damien Lespiau
Modified: 2011-09-05 00:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Damien Lespiau 2011-08-30 23:46:40 UTC 
It has been pointed out that when playbin2 fires EOS and someone sets the state of the pipeline back to playing, we still put the VideoTexture in idle mode which can produce one or more frames with the idle material (back by default).

We could refine the EOS handler with something like

1/ receive EOS
2/ fire the EOS signal on VideoTexture
3/ check the (pending) state of the pipeline after the user callback has been executed
4/ if the pipeline has been set back to playing or pause, don't touch the idle state. Put the VideoTexture in idle mode otherwise.
Comment 1 Damien Lespiau 2011-08-31 23:34:58 UTC 
Fix pushed in master.

commit 2b1af061eabe3f76877c8a083430b4d7892bfd8f
Author: Damien Lespiau <damien.lespiau@intel.com>
Date:   Thu Sep 1 00:29:09 2011 +0100

    media: Refine the idle state management in the EOS callback
    
    So we don't show a black frame when looping the video.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=657773