GNOME Bugzilla – Bug 657754
Change (array zero-terminated=1) annotation syntax
Last modified: 2015-03-03 21:13:47 UTC
I think is enough to use (array zero-terminated) than the actual syntax.
On the pro side, this would match (transfer foo). The con is that we're on a slippery slope to "stuff between parenthesis" as our syntax.
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]
Created attachment 298025 [details] [review] scanner: allow (array zero-terminated) instead of (array zero-terminated=1) Proposed patch because we're already there with "stuff between parenthesis" as our syntax...
Review of attachment 298025 [details] [review]: Incomplete and doesn't pass distcheck. Improved patch coming up soon, but not today...
Created attachment 298130 [details] [review] scanner: allow (array zero-terminated) instead of (array zero-terminated=1) Improved version that actually passes distcheck. What we already had: - (array zero-terminated=1) > array which is NULL terminated - (array zero-terminated=0) > array which is not NULL terminated - (array) > array which is not NULL terminated What this patch adds: - (array zero-terminated) > array which is NULL terminated
Created attachment 298229 [details] [review] scanner: allow (array zero-terminated) instead of (array zero-terminated=1) Previous patch mishandled the (array zero-terminated=X) case, where X can be anything. So now it becomes: What we already had: - (array zero-terminated=1) > array which is NULL terminated - (array zero-terminated=0) > array which is not NULL terminated - (array) > array which is not NULL terminated - (array zero-terminated=X) > array which is not NULL terminated where X can be anything What this patch adds: - (array zero-terminated) > array which is NULL terminated
Review of attachment 298229 [details] [review]: Looks fine to me.
(In reply to Colin Walters from comment #7) > Review of attachment 298229 [details] [review] [review]: > > Looks fine to me. Pushed as 50dfb46