After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 657654 - Do not mark placeholder strings as translatable
Do not mark placeholder strings as translatable
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Properties page
unspecified
Other Linux
: Normal trivial
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-08-29 22:04 UTC by Daniele Forsi
Modified: 2011-08-30 09:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove unneeded translatable=yes property from some strings (8.44 KB, patch)
2011-08-29 22:04 UTC, Daniele Forsi 		committed Details | Review
Remove translatable=yes, add comment, make strings empty (9.82 KB, patch)
2011-08-30 09:11 UTC, Daniele Forsi 		none Details | Review

Description Daniele Forsi 2011-08-29 22:04:01 UTC 
Created attachment 195122 [details] [review]
Remove unneeded translatable=yes property from some strings

The strings that represent property values are marked as translatable in the .ui file but they are replaced by the corresponding translated strings before the property widget is ever displayed to the user.

Execution flow in bacon_video_widget_properties_new() is:
        xml = totem_interface_load ("properties.ui", TRUE, NULL, NULL);
[...]
        bacon_video_widget_properties_reset (props);
[...]
        gtk_widget_show_all (GTK_WIDGET (props));
Comment 1 Philip Withnall 2011-08-29 22:28:41 UTC 
Review of attachment 195122 [details] [review]:

I think it would make more sense to remove the placeholder strings from the UI file entirely, and replace them with an XML comment saying that the strings are set in code before the UI is displayed.
Comment 2 Daniele Forsi 2011-08-30 09:11:52 UTC 
Created attachment 195165 [details] [review]
Remove translatable=yes, add comment, make strings empty

Removing the strings altgether this makes it more difficult to understand the structure when viewing the widget in Glade as empty labels are actually transparent unless selected.
Comment 3 Bastien Nocera 2011-08-30 09:16:14 UTC 
I actually prefer the first one...