GNOME Bugzilla – Bug 657607
Don't make max volume go up to 11
Last modified: 2011-09-05 12:19:18 UTC
See https://bugzilla.gnome.org/show_bug.cgi?id=649411 for details, but this basically means reverting: commit bdd805a3eea2a4bf88bb77e5ad7da50b0bd9fdd5 Author: Adel Gadllah <adel.gadllah@gmail.com> Date: Wed Feb 9 21:18:20 2011 +0100 volume: Increase maximum by 50% for outputs with decibel support Volume should go up to 150% if the sound card used as output has decibel volume support. https://bugzilla.gnome.org/show_bug.cgi?id=641886
Created attachment 195285 [details] [review] Revert "volume: Increase maximum by 50% for outputs with decibel support" This reverts commit bdd805a3eea2a4bf88bb77e5ad7da50b0bd9fdd5. Conflicts: js/ui/status/volume.js
Note, untested. This needs to go in 3.2.
Review of attachment 195285 [details] [review]: Looks good.
What does this mean in terms of UI? The volume slider and keys will only allow going until 100%, and we'll need to go to sound preferences to go above? I agree going beyond 100% without notice has drawbacks, but on several computers I saw, amplification was so weak that users needed to go to 150% in several occasions. Can't we find a way to allow going to 150% while making it clear sound might not be optimal? Maybe by coloring the slider beyond 100%, or by showing a tick mark? Generally, the fact that we allow going to 150% in the sound preferences is the sign that this can be useful. If it is, I think the volume indicator should be more or less consistent with it.
(In reply to comment #4) > What does this mean in terms of UI? The volume slider and keys will only allow > going until 100%, and we'll need to go to sound preferences to go above? Yes. > Generally, the fact that we allow going to 150% in the sound preferences is the > sign that this can be useful. If it is, I think the volume indicator should be > more or less consistent with it. Maybe a use case for another <alt>ernative?
(In reply to comment #5) > Maybe a use case for another <alt>ernative? Maybe. Or when people use mouse scrolling or volume keys, allow them to go past 100% if they continue scrolling/hitting keys (which probably means they consider the current volume isn't enough for them). The important part is that there's a visual feedback that they are asking the OS to go beyond normal sound amplification. Let's hear what designers think about this.
Pushed. Please create a separate bug if you want the functionality re-added. It's already been discussed that the default implementation shouldn't allow for > 100% volumes in bug 649411 (by both sound people at the Desktop Summit, and designers). Attachment 195285 [details] pushed as d99a2f1 - Revert "volume: Increase maximum by 50% for outputs with decibel support"
Fair enough. I've filed bug 658248.