GNOME Bugzilla – Bug 657565
Banshee has some unchangeable accels in the menu
Last modified: 2011-09-11 17:24:17 UTC
From https://bugs.launchpad.net/ubuntu/+source/banshee/+bug/836136: Some actions in the menu have unconfigurable accels, even after setting /desktop/gnome/interface/can_change_accels to true. These are caused by ActionEntry being constructed with null accels as opposed to "" (empty string).
Created attachment 194973 [details] [review] Patch to fix unconfigurable accels
Review of attachment 194973 [details] [review]: From what I can see, the accelerators are editable for actions that don't have a stock_id set (the 2nd parameter to ActionEntry). So this patch only makes a difference for the actions that have stock_id set, like TrackPropertiesAction. According to the docs, in this case, this overrides any default accelerator defined for that stock action. So I'm not sure we want those accelerators to be overridable. But I'm a bit fuzzy on that "stock" thing, so I'd be happy to be enlightened... See also : http://developer.gnome.org/gtk/stable/GtkActionGroup.html#gtk-action-group-add-action-with-accel
Created attachment 196210 [details] [review] Updated patch that does not override accelerators of stock items This patch avoids overriding the accelerators of stock items as mentioned in the previous comment.
Review of attachment 196210 [details] [review]: Committed, thanks !
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.