After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 657549 - add GRL_METADATA_KEY_TRACK_NUMBER
add GRL_METADATA_KEY_TRACK_NUMBER
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: core
git master
Other Linux
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2011-08-28 12:49 UTC by Jonathan Matthew
Modified: 2011-09-02 16:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add GRL_METADATA_KEY_TRACK_NUMBER (4.57 KB, patch)
2011-08-30 15:20 UTC, Juan A. Suarez Romero 		committed Details | Review

Description Jonathan Matthew 2011-08-28 12:49:37 UTC 
This is kind of an obvious property to include, though it seems only the upnp plugin would be able to supply it.
Comment 1 Juan A. Suarez Romero 2011-08-30 15:00:58 UTC 
Yes, seems obvious. I don't know why we didn't include it :)

I think it makes sense not only in UPnP, but in any plugin providing songs from an album.

I'll add it.

Thanks.
Comment 2 Juan A. Suarez Romero 2011-08-30 15:20:21 UTC 
Created attachment 195217 [details] [review]
Add GRL_METADATA_KEY_TRACK_NUMBER

Patch for further review before pushing it to upstream (just in case someone is interested).

It adds GRL_METADATA_KEY_TRACK_NUMBER into Grilo, as well as API to handle it in GrlMediaAudio, as it is where the new key makes more sense.
Comment 3 Juan A. Suarez Romero 2011-09-02 16:17:01 UTC 
Review of attachment 195217 [details] [review]:

Committed as:


commit 832547ea7cf83fdf7bd4629d43640a36b094b800
Author: Juan A. Suarez Romero <jasuarez@igalia.com>
Date:   Tue Aug 30 15:16:41 2011 +0000

    core: Add GRL_METADATA_KEY_TRACK_NUMBER
    
    Add a key for Track Number.
    
    Add also required API in GrlMediaAudio to handle this key.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=657549
    
    Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com>

 src/data/grl-media-audio.c |   26 ++++++++++++++++++++++++++
 src/data/grl-media-audio.h |    4 ++++
 src/grl-metadata-key.c     |   10 ++++++++++
 src/grl-metadata-key.h     |    1 +
 4 files changed, 41 insertions(+), 0 deletions(-)