After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 657495 - [d3dvideosink] Fix device initialization check
[d3dvideosink] Fix device initialization check
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Windows
: Normal normal
: 0.10.24
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 657494 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-08-27 11:15 UTC by Andoni Morales
Modified: 2012-02-07 11:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix device initialization check (1.21 KB, patch)
2011-08-27 11:15 UTC, Andoni Morales 		committed Details | Review

Description Andoni Morales 2011-08-27 11:15:51 UTC 
Created attachment 194913 [details] [review]
fix device initialization check

When the device is initialize in the NULL_TO_READY state change, we always returns successfully, even if the device was not initialized properly. This behaviour doesn't allow switching to a different video sink using autovideosink, for instance.

The following patch patch checks that the device was initialized properly and if not return a state change failure in the null to ready transition.
Comment 1 David Schleef 2011-08-30 23:29:36 UTC 
Looks good.  Please push.
Comment 2 David Schleef 2011-08-30 23:30:40 UTC 
*** Bug 657494 has been marked as a duplicate of this bug. ***
Comment 3 Andoni Morales 2011-08-31 00:51:29 UTC 
I don't have commit access. Can you push it?
Comment 4 David Schleef 2011-08-31 01:07:43 UTC 
Of course, same for patches in other bug reports.  Sorry, I thought you had commit access.
Comment 5 Sebastian Dröge (slomo) 2011-09-07 11:11:22 UTC 
Any progress here?
Comment 6 Sebastian Dröge (slomo) 2012-02-07 11:39:59 UTC 
commit d3b1488fa734b4aa025845feb0590bf46d0983f5
Author: Andoni Morales Alastruey <ylatuya@gmail.com>
Date:   Sat Aug 27 13:07:00 2011 +0200

    d3dvideosink: Fix device initialization check