After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 657479 - Default smartplaylists that are empty are not hidden anymore
Default smartplaylists that are empty are not hidden anymore
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Smart Playlists
git master
Other Linux
: Normal normal
: ---
Assigned To: Andrés G. Aragoneses (IRC: knocte)
Banshee Maintainers
: 641412 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-08-26 22:14 UTC by Andrés G. Aragoneses (IRC: knocte)
Modified: 2011-09-04 09:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (3.54 KB, patch)
2011-08-27 12:54 UTC, Andrés G. Aragoneses (IRC: knocte) 		committed Details | Review

Description Andrés G. Aragoneses (IRC: knocte) 2011-08-26 22:14:52 UTC 
In the past weeks/months I've noticed that now my default smart playlists that contain no elements are not hidden anymore.

(Effectively making this bug a regression of this feature: http://permalink.gmane.org/gmane.comp.gnome.svn/354909 , which was announced here: http://banshee.fm/download/archives/1-7-5/ )

Instead, when I click on them it's when they get hidden, causing a very strange effect.

So the expected result is that, either we show them and they don't disappear when clicked (and are simply empty), or we don't show them at all until they have elements.
Comment 1 Andrés G. Aragoneses (IRC: knocte) 2011-08-26 23:08:08 UTC 
Huh, just realised that this only happens in the gtk3 branch.
Comment 2 Andrés G. Aragoneses (IRC: knocte) 2011-08-26 23:18:10 UTC 
(In reply to comment #1)
> Huh, just realised that this only happens in the gtk3 branch.

I take that back! I just reproduced it again in master.
Comment 3 Andrés G. Aragoneses (IRC: knocte) 2011-08-27 12:54:19 UTC 
Created attachment 194919 [details] [review]
Proposed patch

This is actually my 2nd patch (but I discarded the first one and didn't post it because some reasons I stated in the commit message of this patch)
Comment 4 Andrés G. Aragoneses (IRC: knocte) 2011-08-31 00:39:54 UTC 
*** Bug 641412 has been marked as a duplicate of this bug. ***
Comment 5 Alexander Kojevnikov 2011-09-04 04:32:01 UTC 
Review of attachment 194919 [details] [review]:

Looks good.
Comment 6 Bertrand Lorentz 2011-09-04 09:43:07 UTC 
Comment on attachment 194919 [details] [review]
Proposed patch

Committed, thanks !
Comment 7 Bertrand Lorentz 2011-09-04 09:43:20 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.