After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 657474 - Gnome-Shell Extensions management broken
Gnome-Shell Extensions management broken
Status: RESOLVED FIXED
Product: gnome-tweak-tool
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Tweak Tool maintainer(s)
GNOME Tweak Tool maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-08-26 20:23 UTC by Rico Tzschichholz
Modified: 2017-06-06 19:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix g-s extension management (2.09 KB, patch)
2011-08-26 20:23 UTC, Rico Tzschichholz 		committed Details | Review

Description Rico Tzschichholz 2011-08-26 20:23:55 UTC 
Created attachment 194880 [details] [review]
fix g-s extension management

With the current git of gnome-shell the extension handling is broken.
Comment 1 John Stowers 2011-08-28 00:39:54 UTC 
Rico,

I just committed some code to make extension management work on 3.0 and 3.2 (I dont have a 3.2 install yet).

Can you please test this works on 3.2 / git.

Thanks

John
Comment 2 Rico Tzschichholz 2011-08-28 13:29:38 UTC 
Seems broken now.

WARNING : Error listing extensions
Traceback (most recent call last):

+ Trace 228248

  • File "/usr/lib/python2.7/dist-packages/gtweak/tweaks/tweak_shell_extensions.py", line 153 in __init__ 
    for extension in shell.list_extensions().values():
AttributeError: GnomeShell32 instance has no attribute 'list_extensions' 






Comment 3


John Stowers





          2011-08-29 00:36:08 UTC
        



(In reply to comment #2)
> Seems broken now.
> 
> WARNING : Error listing extensions
> Traceback (most recent call last):
>   File
> "/usr/lib/python2.7/dist-packages/gtweak/tweaks/tweak_shell_extensions.py",
> line 153, in __init__
>     for extension in shell.list_extensions().values():
> 

Yip, I'm an idiot. I forgot to implement that method using the new API in 3.2

The fix is approximately

def list_extensions(self)
    return self._proxy.ListExtensions()

If dbus marshalls the types correctly the result should be the same as the 3.0 call (because ListExtensions returns the same extensionMeta object anyway)

I will fix this tonight.






Comment 4


John Stowers





          2011-08-29 23:17:55 UTC
        



Rico, can you test this again please?






Comment 5


Rico Tzschichholz





          2011-08-30 09:30:31 UTC
        



Sorry for the delay. Unfortunatelly it still isnt working. I havent time to look into it, so I am just pasting the trace. (Havent tested it with gnome-shell 3.1.90 yet, but should be a same result)

WARNING : Could not list shell extensions
Traceback (most recent call last):




+
Trace
    228266






    

  • 
          File "/usr/lib/python2.7/dist-packages/gtweak/tweaks/tweak_shell.py",
          line 62
            in __init__

    extensions = self._shell.list_extensions()
    

    • 

  • 
          File "/usr/lib/python2.7/dist-packages/gtweak/gshellwrapper.py",
          line 106
            in list_extensions

    return self._proxy.ListExtensions()
    

    • 


AttributeError: _ShellProxy instance has no attribute 'ListExtensions'





WARNING : Error listing extensions
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/gtweak/tweaks/tweak_shell_extensions.py", line 153, in __init__
    for extension in shell.list_extensions().values():
  File "/usr/lib/python2.7/dist-packages/gtweak/gshellwrapper.py", line 106, in list_extensions
    return self._proxy.ListExtensions()
AttributeError: _ShellProxy instance has no attribute 'ListExtensions'






Comment 6


John Stowers





          2011-08-30 12:03:01 UTC
        



(In reply to comment #5)
> Sorry for the delay. Unfortunatelly it still isnt working. I havent time to
> look into it, so I am just pasting the trace. (Havent tested it with
> gnome-shell 3.1.90 yet, but should be a same result)

Yeah, I pushed another fix. Can you test again please?

Sorry that I can't test this more thoroughly.

Thanks for your help.






Comment 7


Rico Tzschichholz





          2011-08-30 12:46:02 UTC
        



It works now ;)






Comment 8


John Stowers





          2011-10-22 02:42:09 UTC
        



This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.