After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 657393 - [gstwidget] Clear button does not reset text fields
[gstwidget] Clear button does not reset text fields
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: General
Git
Other Linux
: Normal minor
: 0.91
Assigned To: Pitivi maintainers
Pitivi maintainers
Depends on:
Blocks:
 
 
Reported: 2011-08-26 01:22 UTC by Jean-François Fortin Tam
Modified: 2012-04-08 13:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Attaching a quick fix for the string types. (339 bytes, patch)
2012-04-01 12:21 UTC, Ajay Deshpande 		needs-work Details | Review
Passing default value to TextWidget (534 bytes, patch)
2012-04-03 13:10 UTC, Ajay Deshpande 		needs-work Details | Review

Description Jean-François Fortin Tam 2011-08-26 01:22:08 UTC 
If I click the reset/clear button in the advanced codec properties, text fields such as the "Statistics Filename" (in the case of the xvid codec) are not reset to their default value (such as "xvid-stats.log").
Comment 1 Ajay Deshpande 2012-04-01 12:21:59 UTC 
Created attachment 211072 [details] [review]
Attaching a quick fix for the string types.

The default value is not set in case of a String. So setting it.
Comment 2 Ajay Deshpande 2012-04-02 04:48:34 UTC 
The patch is for pitivi built using GES.
Comment 3 Jean-François Fortin Tam 2012-04-02 14:44:57 UTC 
Review of attachment 211072 [details] [review]:

Hi, the python convention is to use 1 tab = 4 spaces, so you have to set your text editor to use 4 spaces or it will break.

Also, the proposed fix doesn't work from my testing (and from a theoretical point of view, setWidgetValue is not the place where you would set a default value, it would get overriden everytime).
Comment 4 Jean-François Fortin Tam 2012-04-02 15:03:58 UTC 
The problem *might* be in the make_property_widget method, or something to do with GstElementSettingsWidget.
Comment 5 Ajay Deshpande 2012-04-03 13:10:34 UTC 
Created attachment 211221 [details] [review]
Passing default value to TextWidget

The problem was indeed with make_property_widget. Passing the default value of the string to the TextWidget clears the property to its default value.
Comment 6 Jean-François Fortin Tam 2012-04-05 22:24:29 UTC 
Review of attachment 211221 [details] [review]:

Hi, your patch needs to be rebased on ges (it is based on master). Also, it does not actually fix the problem, something else must be missing.
Comment 7 Jean-François Fortin Tam 2012-04-08 13:25:56 UTC 
I found the complete fix, pushed as da1b9a217.