After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 657377 - srcdir!=builddir builds discard contents of tmpl
srcdir!=builddir builds discard contents of tmpl
Status: RESOLVED FIXED
Product: gtk-doc
Classification: Platform
Component: general
1.17
Other Linux
: Normal normal
: 1.18
Assigned To: gtk-doc maintainers
gtk-doc maintainers
Depends on:
Blocks:
 
 
Reported: 2011-08-25 20:26 UTC by Miloslav Trmac
Modified: 2011-08-31 11:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Miloslav Trmac 2011-08-25 20:26:14 UTC 
The setup-build.stamp rule in gtk-doc 1.17 contains:
>	   test -f $(abs_srcdir)/tmpl && \
>	       cp -rp $(abs_srcdir)/tmpl $(abs_builddir)/; \

Because tmpl is supposed to be a directory, the test never succeeds.  It should use -d or perhaps even -e (to allow symbolic links).
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2011-08-25 20:46:58 UTC 
Thanks!

commit aedc1d731a414be1e94893f050b47ee2934c60cd
Author: Stefan Kost <ensonic@users.sf.net>
Date:   Thu Aug 25 22:44:04 2011 +0200

    make: fix setup for tmpl based projects
    
    The test for the directory was using -f which should have been -d.
    Fixes #657377
Comment 2 Miloslav Trmac 2011-08-25 21:09:12 UTC 
Thanks, but that's apparently not enough for (make distcheck).  I now use

>	   test -d $(abs_srcdir)/tmpl && \
>	       { cp -r $(abs_srcdir)/tmpl $(abs_builddir)/; \
>		 chmod -R u+w $(abs_builddir)/tmpl; } \
Comment 3 Stefan Sauer (gstreamer, gtkdoc dev) 2011-08-25 21:24:46 UTC 
Good catch, we're copying it from the srcdir and in distcheck its read-only.

commit bea7a41be032678d8d414d72622b98e6a82dff25
Author: Stefan Kost <ensonic@users.sf.net>
Date:   Thu Aug 25 23:20:44 2011 +0200

    make: fix distcheck for tmpl based projects
    
    Make the tmpl dir we copied in setup writable (as during distcheck the source
    is readonly).