GNOME Bugzilla – Bug 657364
gnome-settings-daemon crashed with SIGFPE in g_main_context_dispatch()
Last modified: 2011-09-07 16:51:12 UTC
this report has been filed here: https://bugs.launchpad.net/ubuntu/+source/gnome-settings-daemon/+bug/833595 "System Settings - then Screen Background - then crash report is starting" ".
+ Trace 228210
Thread 1 (Thread 0x7fa327e09940 (LWP 1401))
Created attachment 195223 [details] [review] power: Fix impossible to hit error paths guint is always positive, so "value < 0" will never catch errors, and might cause crashers.
Attachment 195223 [details] pushed as 30060b2 - power: Fix impossible to hit error paths
Rodrigo, when I say that there is a bug in gnome-desktop or in the backlight helper, I'd appreciate if you didn't commit a gross work-around for the problem. commit e64a5d0b56d551c653027a6040ccfa28fbd101e5 Author: Bastien Nocera <hadess@hadess.net> Date: Wed Sep 7 16:32:35 2011 +0100 power: Reset value to -1 when parsing failed When we fail to parse the value output of the backlight helper, also reset the value, as g_ascii_strtoll() returns 0 on failure. https://bugzilla.gnome.org/show_bug.cgi?id=657364 commit 8c61c54ba6248891541d5d849d1d9871ad3c4940 Author: Bastien Nocera <hadess@hadess.net> Date: Wed Sep 7 16:31:13 2011 +0100 power: Correctly check for helper exit status By using WEXITSTATUS() and not relying solely on the return value of g_spawn_command_line_sync(). https://bugzilla.gnome.org/show_bug.cgi?id=657364 commit 5be38144f19d1479c908039ffc2991052b06111b Author: Bastien Nocera <hadess@hadess.net> Date: Wed Sep 7 16:18:46 2011 +0100 power: Make ABS_TO_PERCENTAGE warn on invalid input Works around this problem, whilst producing a warning. https://bugzilla.gnome.org/show_bug.cgi?id=657364 commit 7742a3bc9619eb79fdf212ab835c2b706ef7e856 Author: Bastien Nocera <hadess@hadess.net> Date: Wed Sep 7 15:57:01 2011 +0100 Revert "power: Guard against dividing by 0 in ABS_TO_PERCENTAGE macro" This reverts commit fcd4e082cc1528b633b7d07732adb2921d244ab8. This is the wrong fix, as we have gnome-desktop or the backlight helper giving us back garbage. We want to fix that, not work-around the problem with sticky tape. And reopen if you manage to reproduce this problem with the above patches.
infos that Rodrigo asked on the ubuntu bug "$ /usr/lib/gnome-settings-daemon/gsd-backlight-helper --get-max-brightness No backlights were found on your system $ /usr/lib/gnome-settings-daemon/gsd-backlight-helper --get-brightness No backlights were found on your system This is a real hardware, desktop with two LCD monitors and NVIDIA card."
seems it's an issue for virtualbox users as well. Rodrigo could you backport the patches to the current oneiric package and see if that solves the issue?
(In reply to comment #4) > infos that Rodrigo asked on the ubuntu bug > > "$ /usr/lib/gnome-settings-daemon/gsd-backlight-helper --get-max-brightness > No backlights were found on your system > $ /usr/lib/gnome-settings-daemon/gsd-backlight-helper --get-brightness > No backlights were found on your system > > This is a real hardware, desktop with two LCD monitors and NVIDIA card." That would be what 8c61c54ba6248891541d5d849d1d9871ad3c4940 corrects then.